[jira] [Resolved] (FOP-2317) FOP warning causing a crash

["Vincent Hennebert (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FOP-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vincent Hennebert resolved FOP-2317.
------------------------------------

    Resolution: Fixed

Hi Seifeddine,

thanks for your patch. I've committed it in [rev. 1544199|http://svn.apache.org/r1544199].

This part of the code is really less than ideal. Instead of iterating again through the attribute list in search for the attribute name that had the wrong value, the attribute name should be passed all the way through. Then it could be displayed straight away. If you feel like improving that...

Thanks anyway!
Vincent

> FOP warning causing a crash
> ---------------------------
>
>                 Key: FOP-2317
>                 URL: https://issues.apache.org/jira/browse/FOP-2317
>             Project: Fop
>          Issue Type: Bug
>          Components: general
>    Affects Versions: trunk
>         Environment: Windows 7
>            Reporter: Seifeddine Dridi
>            Priority: Minor
>         Attachments: patch.diff, warning_problem.fo
>
>
> <fo:table-cell width="" border-left="0.5pt green dashed">
> <fo:block>Cell</fo:block>
> </fo:table-cell>
> FOP issues a warning because border-left has an invalid structure (the border-style should be placed before the border-color). 
> In FObj.warnOnUnknownProperties(), there is a call to getAttributeNameForValue() to find the name of the attribute whose value is unknown, then it stumbles on the width="" property, which returns a null object when instantiated. And there goes a NPE which leads to a crash:
> if (prop.equals(value)) {
>     return attributeName;
> }
> I attached a patch which encloses the above code with a simple if-test.



--
This message was sent by Atlassian JIRA
(v6.1#6144)