You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2016/02/24 21:59:18 UTC

[jira] [Updated] (OAK-4054) FileStore.containsSegment returns alway true (almost)

     [ https://issues.apache.org/jira/browse/OAK-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig updated OAK-4054:
-------------------------------
    Labels: compaction gc stability  (was: compaction gc)

> FileStore.containsSegment returns alway true (almost)
> -----------------------------------------------------
>
>                 Key: OAK-4054
>                 URL: https://issues.apache.org/jira/browse/OAK-4054
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segmentmk
>            Reporter: Michael Dürig
>              Labels: compaction, gc, stability
>
> {{FileStore.containsSegment()}} looks [funky|https://github.com/mduerig/jackrabbit-oak/blob/36cb3bf6e5078e3afa75581fb789eeca7b5df2e2/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/FileStore.java#L1197-L1197]. This "optimisation" causes it to always return {{true}}. 
> {{containsSegment}} is used for deduplication and revision gc. The current implementation causes {{SNFE}} exceptions once gc is effective (as I experienced while working on OAK-3348). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)