You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/03/29 19:08:07 UTC

[GitHub] [bookkeeper] dlg99 opened a new pull request #2664: fix: Bookkeeper client throttling logic is based upon entryId instead of ledgerId

dlg99 opened a new pull request #2664:
URL: https://github.com/apache/bookkeeper/pull/2664


   
   Descriptions of the changes in this PR:
   
   Fixes: #2660 
   
   ### Changes
   
   isWriteSetWritable() to use ledgerId for the client selection
   
   Master Issue: #2660 
   
   > ---
   > In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
   > checks for pull requests. A pull request can only be merged when it passes precommit checks.
   >
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > 
   > ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] pkumar-singh commented on pull request #2664: fix: Bookkeeper client throttling logic is based upon entryId instead of ledgerId

Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2664:
URL: https://github.com/apache/bookkeeper/pull/2664#issuecomment-821560918


   We can get rid of the template text from PR message. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] dlg99 merged pull request #2664: fix: Bookkeeper client throttling logic is based upon entryId instead of ledgerId

Posted by GitBox <gi...@apache.org>.
dlg99 merged pull request #2664:
URL: https://github.com/apache/bookkeeper/pull/2664


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] dlg99 commented on pull request #2664: fix: Bookkeeper client throttling logic is based upon entryId instead of ledgerId

Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #2664:
URL: https://github.com/apache/bookkeeper/pull/2664#issuecomment-809696510


   > didn't we have tests that covered this "feature" ?
   
   Tests use client config with numChannelsPerBookie == 1. :( All tests.
   I think this can be tracked/fixed separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org