[GitHub] verdan commented on a change in pull request #4613: [AIRFLOW-3749] Fix Edit Dag Run page when using RBAC

[GitBox <gi...@apache.org>]

verdan commented on a change in pull request #4613: [AIRFLOW-3749] Fix Edit Dag Run page when using RBAC
URL: https://github.com/apache/airflow/pull/4613#discussion_r252195791
 
 

 ##########
 File path: airflow/www/templates/airflow/dag.html
 ##########
 @@ -521,7 +521,7 @@ <h4 class="modal-title" id="dagModalLabel">
     });
 
     $('#btn_edit_dagrun').click(function() {
-      window.location = "{{ url_for('DagModelView.show', pk=dag.dag_id) }}";
+      window.location = "{{ url_for('DagModelView.edit', pk=dag.dag_id) }}";
 
 Review comment:
   that would be awesome!! I was also working on a PR to extract all inline JS from .html files to separate .js files. 
   I was using `data-url` attribute to move all the URLs inside html and use this attribute to access the url in .js files. 
   P.S: I'll continue working on that in coming weeks, as was busy removing the old UI before. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services