You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/01/25 11:08:16 UTC

Review Request 55923: AMBARI-19604:Need to perform sanity checks before starting the oozie view

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55923/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-19604
    https://issues.apache.org/jira/browse/AMBARI-19604


Repository: ambari


Description
-------

Added sanity checks for oozie, hdfs and user home directory


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 23609e9 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/design-loading.hbs PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/loading.hbs 9f4fc79 

Diff: https://reviews.apache.org/r/55923/diff/


Testing
-------

Manual testing


Thanks,

Padma Priya N

Re: Review Request 55923: AMBARI-19604:Need to perform sanity checks before starting the oozie view

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55923/#review163230
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 25, 2017, 11:08 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55923/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 11:08 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19604
>     https://issues.apache.org/jira/browse/AMBARI-19604
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added sanity checks for oozie, hdfs and user home directory
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 23609e9 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/design-loading.hbs PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/loading.hbs 9f4fc79 
> 
> Diff: https://reviews.apache.org/r/55923/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55923: AMBARI-19604:Need to perform sanity checks before starting the oozie view

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55923/#review162974
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On Jan. 25, 2017, 11:08 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55923/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 11:08 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19604
>     https://issues.apache.org/jira/browse/AMBARI-19604
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added sanity checks for oozie, hdfs and user home directory
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 23609e9 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/design-loading.hbs PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/loading.hbs 9f4fc79 
> 
> Diff: https://reviews.apache.org/r/55923/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55923: AMBARI-19604:Need to perform sanity checks before starting the oozie view

Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55923/#review163467
-----------------------------------------------------------




contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js (line 99)
<https://reviews.apache.org/r/55923/#comment234954>

    X-Requested-By is generally set to 'ambari'. is there any specific reason to set it to 'workflow-designer'



contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs (line 21)
<https://reviews.apache.org/r/55923/#comment234955>

    Extract constants to make it i18n compliant


- Nitiraj Rathore


On Jan. 25, 2017, 11:08 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55923/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 11:08 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19604
>     https://issues.apache.org/jira/browse/AMBARI-19604
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added sanity checks for oozie, hdfs and user home directory
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 23609e9 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/design-loading.hbs PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/loading.hbs 9f4fc79 
> 
> Diff: https://reviews.apache.org/r/55923/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>