You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/18 05:20:41 UTC

[GitHub] [dubbo] zrlw commented on pull request #8833: [3.0] add zookeeper node data created event check

zrlw commented on pull request #8833:
URL: https://github.com/apache/dubbo/pull/8833#issuecomment-922187346


   > LGTM, but should add ut.
   
   ZookeeperDynamicConfigurationTest was add ```@Disabled("Disabled Due to Zookeeper in Github Actions")```,  if add test, it might be added into it (dubbo-samples project).
   you could see the issue by setting breakpoint at ```client.setData().forPath(path, data.getBytes());``` in ZookeeperDynamicConfigurationTest and debug any testcase of it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org