You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "zhourunjie1988 (via GitHub)" <gi...@apache.org> on 2024/02/21 07:58:50 UTC
[PR] fix: remove click event after unmounted [skywalking-booster-ui]
zhourunjie1988 opened a new pull request, #372:
URL: https://github.com/apache/skywalking-booster-ui/pull/372
The _handleClick_ function calls the _stopPropagation_, so we'd better remove the click events after component unmounted to prevent potential problems, such as adding click events to the _window_ or _document_ elsewhere won't work correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: remove click event after unmounted [skywalking-booster-ui]
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 merged PR #372:
URL: https://github.com/apache/skywalking-booster-ui/pull/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: remove click event after unmounted [skywalking-booster-ui]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #372:
URL: https://github.com/apache/skywalking-booster-ui/pull/372#issuecomment-1956086982
@Fine0830 Please take a look. This is too detailed about the UI codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org