You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/07/20 18:11:38 UTC
[GitHub] [maven-gpg-plugin] michael-o commented on a change in pull request
#3: [MGPG-71] - Plugin does not work with GPG on OSX based on MacGPG2
michael-o commented on a change in pull request #3: [MGPG-71] - Plugin does not work with GPG on OSX based on MacGPG2
URL: https://github.com/apache/maven-gpg-plugin/pull/3#discussion_r305588588
##########
File path: src/main/java/org/apache/maven/plugin/gpg/GpgVersionParser.java
##########
@@ -90,7 +90,7 @@ public GpgVersion getGpgVersion()
static class GpgVersionConsumer
implements StreamConsumer
{
- private final Pattern gpgVersionPattern = Pattern.compile( "gpg \\(GnuPG\\) .+" );
+ private final Pattern gpgVersionPattern = Pattern.compile( "gpg \\(GnuPG.+\\) .+" );
Review comment:
This will fail for everything else, but your case. It should probably be non-greedy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services