You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Jaydeep Vishwakarma <ja...@gmail.com> on 2015/06/12 10:52:02 UTC
Review Request 35379: OOZIE-2030 Configuration properties from global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-2030
https://issues.apache.org/jira/browse/OOZIE-2030
Repository: oozie-git
Description
-------
Forwarding global conf from workflow to action when action is subworkflow,
subworkflow storing it to property and forwarding as property.
LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
Diffs
-----
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c857011
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
Diff: https://reviews.apache.org/r/35379/diff/
Testing
-------
yes
Thanks,
Jaydeep Vishwakarma
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review90683
-----------------------------------------------------------
Ship it!
Ship It!
- Shwetha GS
On July 7, 2015, 8:57 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 8:57 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c857011
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review91987
-----------------------------------------------------------
OOZIE-2187 changes this piece of code a lot. You will have to rebase and make changes to work with that.
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 445)
<https://reviews.apache.org/r/35379/#comment145763>
Can you also add condition to check for presence of propagate-configuration?
- Rohini Palaniswamy
On July 14, 2015, 1:19 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated July 14, 2015, 1:19 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c857011
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
> On Nov. 30, 2015, 5:06 a.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java, line 709
> > <https://reviews.apache.org/r/35379/diff/7/?file=1017730#file1017730line709>
> >
> > Shouldn't foo3 be actionconf here also?
No it will be foo3 only and it is independent to this patch. Configuration tag has no code to merge with action conf. But both are independently exists in some form to use. In Action executor actionconf have "foo3=foo3" and configuration conf "foo3=actionconf" can be access through context.getworkflow.getConf/context.getprotoconf , And for same reason I have mentioned that value in test case. I will fix it as separate patch as it has no relation with global conf.
- Jaydeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review108278
-----------------------------------------------------------
On Nov. 30, 2015, 7:50 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 7:50 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review108278
-----------------------------------------------------------
Like that the logic is lot more concise than the previous versions and you have made good use of changes in OOZIE-2187. But would like optimization to avoid cost of serializing GlobalSectionData for all workflows which do not even have sub-workflows and also the deserialization of GlobalSectionData done for every action again for all workflows which are unnecessary. Suggested changes below which will serialize global section into jobconf only when there is sub-workflow with propagate-configuration. Also deserialization of GlobalSectionData from jobconf is done only once in the beginning.
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 431)
<https://reviews.apache.org/r/35379/#comment167645>
GlobalSectionData gData = jobConf.get(OOZIE_GLOBAL) == null ? null : getGlobalFromString(jobConf.get(OOZIE_GLOBAL))
boolean serializedGlobalConf = false;
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (lines 474 - 477)
<https://reviews.apache.org/r/35379/#comment167632>
Instead of propagateGlobalConf = true; can we do
if (!serializedGlobalConf && elem.getName().equals(SubWorkflowActionExecutor.ACTION_TYPE) &&
elem.getChild(("propagate-configuration"), ns) != null) {
serializedGlobalConf = true; jobConf.set(OOZIE_GLOBAL, getGlobalString(gData));
}
eActionConf = elem; handleDefaultsAndGlobal(gData, configDefault, elem);
here instead of in eNode.getName().equals(GLOBAL) section and remove
if (!propagateGlobalConf) {
jobConf.unset(OOZIE_GLOBAL);
}
serializedGlobalConf is to avoid serializing multiple times if there is more than one sub-workflow which is the case most of the time.
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (lines 503 - 507)
<https://reviews.apache.org/r/35379/#comment167648>
if(jobConf.get(OOZIE_GLOBAL) != null) {
handleDefaultsAndGlobal(gData, null, eNode);
}
gData = parseGlobalSection(ns, eNode);
gData = parseGlobalSection(ns, eNode); at the beginning before if block needs to be removed. Parse gData only once after the if block.
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 551)
<https://reviews.apache.org/r/35379/#comment167630>
Can you compress before base64 encoding? It is compressed before storing to database. But in some recent issues with hcat we found that conf compresses lot better before base64 encoding than after it. So compressing here should also be good.
Deflater def = new Deflater();
oos = new DataOutputStream(new DeflaterOutputStream(baos, def));
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (lines 643 - 646)
<https://reviews.apache.org/r/35379/#comment167629>
Make it an empty constructor. null is the default value with the variable declaration. If you want it to be explicitly null, assign it to null in the variable declaration itself
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java (line 709)
<https://reviews.apache.org/r/35379/#comment167631>
Shouldn't foo3 be actionconf here also?
- Rohini Palaniswamy
On July 21, 2015, 10:59 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 10:59 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review108386
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 506)
<https://reviews.apache.org/r/35379/#comment167828>
This line should be removed.
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (lines 518 - 520)
<https://reviews.apache.org/r/35379/#comment167827>
This block is not required as it is being set only when propagate-configuration is true.
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 109)
<https://reviews.apache.org/r/35379/#comment167831>
oozie.wf.globalconf
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 508)
<https://reviews.apache.org/r/35379/#comment167834>
if(jobConf.get(OOZIE_GLOBAL) != null) {
gData = getGlobalFromString(jobConf.get(OOZIE_GLOBAL));
handleDefaultsAndGlobal(gData, null, eNode);
}
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 673)
<https://reviews.apache.org/r/35379/#comment167833>
writeUTF(null)
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (lines 736 - 739)
<https://reviews.apache.org/r/35379/#comment167832>
This needs to be removed and GlobalSectionData gData passed as method parameter to avoid deserializing for every action.
- Rohini Palaniswamy
On Nov. 30, 2015, 7:50 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 7:50 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Dec. 21, 2015, 9:12 p.m., Rohini Palaniswamy wrote:
> > Ship It!
Ignore this one. Requested change was in the wrong place. Updated comments below.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review111533
-----------------------------------------------------------
On Dec. 16, 2015, 10:23 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 10:23 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review111533
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Dec. 16, 2015, 10:23 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 10:23 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review111618
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 669)
<https://reviews.apache.org/r/35379/#comment171826>
One last minor thing - WritableUtils.writeStr(dataOutput, null) . Not sure how I missed this earlier.
- Rohini Palaniswamy
On Dec. 22, 2015, 6:49 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 6:49 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/
-----------------------------------------------------------
(Updated Dec. 22, 2015, 6:49 a.m.)
Review request for oozie.
Changes
-------
Yeah , I realised too, wrote the comment and forget to publish :( . Sorry for inconvenience. I have updated the patch according to last comment.
Bugs: OOZIE-2030
https://issues.apache.org/jira/browse/OOZIE-2030
Repository: oozie-git
Description
-------
Forwarding global conf from workflow to action when action is subworkflow,
subworkflow storing it to property and forwarding as property.
LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
Diff: https://reviews.apache.org/r/35379/diff/
Testing
-------
yes
Thanks,
Jaydeep Vishwakarma
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review111534
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java
<https://reviews.apache.org/r/35379/#comment171727>
You had removed it from here and that should not be the case. This needs to be there so that it is only set when there is sub-workflow and propagate conf.
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 510)
<https://reviews.apache.org/r/35379/#comment171728>
This is where it needs to be removed so that it is not set for every workflow having global section
- Rohini Palaniswamy
On Dec. 16, 2015, 10:23 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 10:23 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/
-----------------------------------------------------------
(Updated Dec. 16, 2015, 10:23 a.m.)
Review request for oozie.
Bugs: OOZIE-2030
https://issues.apache.org/jira/browse/OOZIE-2030
Repository: oozie-git
Description
-------
Forwarding global conf from workflow to action when action is subworkflow,
subworkflow storing it to property and forwarding as property.
LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
Diff: https://reviews.apache.org/r/35379/diff/
Testing
-------
yes
Thanks,
Jaydeep Vishwakarma
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Dec. 3, 2015, 4:02 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java, line 512
> > <https://reviews.apache.org/r/35379/diff/9/?file=1149310#file1149310line512>
> >
> > This line needs to be removed. Purpose of my ask to make all these changes is to avoid cost of serializing global conf if there is no sub-workflow with propagate-configuration.
This issue is still there
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review108633
-----------------------------------------------------------
On Nov. 30, 2015, 8:59 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 8:59 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Dec. 3, 2015, 4:02 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java, line 512
> > <https://reviews.apache.org/r/35379/diff/9/?file=1149310#file1149310line512>
> >
> > This line needs to be removed. Purpose of my ask to make all these changes is to avoid cost of serializing global conf if there is no sub-workflow with propagate-configuration.
>
> Rohini Palaniswamy wrote:
> This issue is still there
I reopened the issue on the same day and also commented, but forgot to actually publish the comment and it stayed as a draft. Was wondering why you hadn't replied. Really sorry about that.
jobConf.set(OOZIE_GLOBAL, getGlobalString(gData)); is still not removed in the final patch and that needs to be done.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review108633
-----------------------------------------------------------
On Nov. 30, 2015, 8:59 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 8:59 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review108633
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 511)
<https://reviews.apache.org/r/35379/#comment168088>
This line needs to be removed. Purpose of my ask to make all these changes is to avoid cost of serializing global conf if there is no sub-workflow with propagate-configuration.
- Rohini Palaniswamy
On Nov. 30, 2015, 8:59 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 8:59 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 8:59 p.m.)
Review request for oozie.
Bugs: OOZIE-2030
https://issues.apache.org/jira/browse/OOZIE-2030
Repository: oozie-git
Description
-------
Forwarding global conf from workflow to action when action is subworkflow,
subworkflow storing it to property and forwarding as property.
LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
Diff: https://reviews.apache.org/r/35379/diff/
Testing
-------
yes
Thanks,
Jaydeep Vishwakarma
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 7:50 p.m.)
Review request for oozie.
Bugs: OOZIE-2030
https://issues.apache.org/jira/browse/OOZIE-2030
Repository: oozie-git
Description
-------
Forwarding global conf from workflow to action when action is subworkflow,
subworkflow storing it to property and forwarding as property.
LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
Diff: https://reviews.apache.org/r/35379/diff/
Testing
-------
yes
Thanks,
Jaydeep Vishwakarma
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
> On Sept. 25, 2015, 5:33 a.m., Srikanth Sundarrajan wrote:
> > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java, line 507
> > <https://reviews.apache.org/r/35379/diff/7/?file=1017729#file1017729line507>
> >
> > gData is already populated with Global section data. Is this necessary ?
Yes, it is necesarry, When jobConf.get(OOZIE_GLOBAL) have global conf , we have have to merge it with current global conf.
- Jaydeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review100531
-----------------------------------------------------------
On July 21, 2015, 10:59 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 10:59 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review100531
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 506)
<https://reviews.apache.org/r/35379/#comment157752>
gData is already populated with Global section data. Is this necessary ?
- Srikanth Sundarrajan
On July 21, 2015, 10:59 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 10:59 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/
-----------------------------------------------------------
(Updated July 21, 2015, 10:59 a.m.)
Review request for oozie.
Changes
-------
I have rebased the patch after OOZIE-2187, I have to do the following changes:
As global conf passing as object, No way to view it in xml hence serializing and compressing it.
handleDefaultsAndGlobal method had so many changes. Subworkflow cannot use global conf as it fails in all conditions. I have made some changes which will fix this issue.
Another change made for merging global conf in same handleDefaultsAndGlobal, before OOZIE-2187 it was not required.
Bugs: OOZIE-2030
https://issues.apache.org/jira/browse/OOZIE-2030
Repository: oozie-git
Description
-------
Forwarding global conf from workflow to action when action is subworkflow,
subworkflow storing it to property and forwarding as property.
LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
Diff: https://reviews.apache.org/r/35379/diff/
Testing
-------
yes
Thanks,
Jaydeep Vishwakarma
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/
-----------------------------------------------------------
(Updated July 14, 2015, 1:19 p.m.)
Review request for oozie.
Changes
-------
Avoiding to store oozie.globalconf property when there is no subworkflow action
Bugs: OOZIE-2030
https://issues.apache.org/jira/browse/OOZIE-2030
Repository: oozie-git
Description
-------
Forwarding global conf from workflow to action when action is subworkflow,
subworkflow storing it to property and forwarding as property.
LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c857011
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
Diff: https://reviews.apache.org/r/35379/diff/
Testing
-------
yes
Thanks,
Jaydeep Vishwakarma
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/
-----------------------------------------------------------
(Updated July 13, 2015, 12:38 p.m.)
Review request for oozie.
Bugs: OOZIE-2030
https://issues.apache.org/jira/browse/OOZIE-2030
Repository: oozie-git
Description
-------
Forwarding global conf from workflow to action when action is subworkflow,
subworkflow storing it to property and forwarding as property.
LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c857011
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
Diff: https://reviews.apache.org/r/35379/diff/
Testing
-------
yes
Thanks,
Jaydeep Vishwakarma
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/
-----------------------------------------------------------
(Updated July 13, 2015, 11:28 a.m.)
Review request for oozie.
Changes
-------
Added an assert for action conf property, And fixed one javadoc issue.
Bugs: OOZIE-2030
https://issues.apache.org/jira/browse/OOZIE-2030
Repository: oozie-git
Description
-------
Forwarding global conf from workflow to action when action is subworkflow,
subworkflow storing it to property and forwarding as property.
LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c857011
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
Diff: https://reviews.apache.org/r/35379/diff/
Testing
-------
yes
Thanks,
Jaydeep Vishwakarma
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/
-----------------------------------------------------------
(Updated July 7, 2015, 8:57 a.m.)
Review request for oozie.
Bugs: OOZIE-2030
https://issues.apache.org/jira/browse/OOZIE-2030
Repository: oozie-git
Description
-------
Forwarding global conf from workflow to action when action is subworkflow,
subworkflow storing it to property and forwarding as property.
LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c857011
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
Diff: https://reviews.apache.org/r/35379/diff/
Testing
-------
yes
Thanks,
Jaydeep Vishwakarma
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review90468
-----------------------------------------------------------
Ship it!
This is a much simpler and cleaner implementation for this feature. +1
- Srikanth Sundarrajan
On June 16, 2015, 12:06 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 12:06 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c857011
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review90671
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 95)
<https://reviews.apache.org/r/35379/#comment143804>
rename to oozie.globalconf
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 488)
<https://reviews.apache.org/r/35379/#comment143806>
add a comment that this merges the parent global conf and current global conf. Then sets the merged global conf in jobConf
Minor comments, looks good otherwise. Simpler and nice approach. Thanks
- Shwetha GS
On June 16, 2015, 12:06 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 12:06 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c857011
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/
-----------------------------------------------------------
(Updated June 16, 2015, 12:06 p.m.)
Review request for oozie.
Changes
-------
No change specific to subworkflow. Global config of workflow will reach to every workflow actions.
Bugs: OOZIE-2030
https://issues.apache.org/jira/browse/OOZIE-2030
Repository: oozie-git
Description
-------
Forwarding global conf from workflow to action when action is subworkflow,
subworkflow storing it to property and forwarding as property.
LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c857011
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
Diff: https://reviews.apache.org/r/35379/diff/
Testing
-------
yes
Thanks,
Jaydeep Vishwakarma