[GitHub] [flink] walterddr edited a comment on issue #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate

[GitBox <gi...@apache.org>]

walterddr edited a comment on issue #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate
URL: https://github.com/apache/flink/pull/8389#issuecomment-491870036
 
 
   Thanks for the review @beyond1920 . Yes I agree that the solution is mostly a bare minimum to fix the bug at this moment. I was actually trying to re-architecture the way how `TableSource` interfaces works, since the `explainSource` extends from `TableSource` it doesn't actually contain any information of whether this is a predicate push-down source type. Also none of the above mentioned `*TableSource` interface extends from `TableSource`.
   
   However changing the API might take some time for designing. I will start a design doc and attached to the JIRA discussion, what do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services