You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/12/30 05:45:47 UTC
[GitHub] zeppelin pull request #1822: [ZEPPELIN-1789] Make exported data file name mo...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1822
[ZEPPELIN-1789] Make exported data file name more explicit
### What is this PR for?
Currently we can download table data set as `.csv` or `.tsv` format in Zeppelin note. But since the exported file name is always set as `data.csv`, it will be difficult to distinguish the each file if user tries to export it several times. So I changed the naming rule like below.
1. if the paragraph has title e.g. `this is title`, then the exported csv file name will be
`this is title_YYYY-MM-DD hh:mm:ss a.csv` .
2. if not, the file name will be `Exported data_YYYY-MM-DD hh:mm:ss a.csv` .
Please see the short discussion in [ZEPPELIN-1789](https://issues.apache.org/jira/browse/ZEPPELIN-1789) for the more details. I just made this PR by following one person's opinion who raised this issue (_Ruslan Dautkhanov_ ). So if anyone has better idea, please feel free to share :)
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-1789](https://issues.apache.org/jira/browse/ZEPPELIN-1789)
### How should this be tested?
1. run Zeppelin web dev mode under `zeppelin-web`
```
$ npm run dev
```
2. browse `http://localhost:9000` and go to Zeppelin-Spark tutorial note
3. click 
If the paragraph has title, then the exported file name will be `"paragraph_title_YYYY-MM-DD hh:mm:ss a".csv`, if not, will be `"Exported data_YYYY-MM-DD hh:mm:ss a".csv`.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1789
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1822.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1822
----
commit 64c3e183bab19a7b3768edda01d78cc809bb56d9
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-12-30T05:21:37Z
Make exported data file name more explicit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1822: [ZEPPELIN-1789] Make exported data file name more expl...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1822
@Leemoonsoo Sounds good. Let me update then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1822: [ZEPPELIN-1789] Make exported data file name more expl...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1822
CI failure is not related this issue
```
Results :
Failed tests:
NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760 expected:<ABORT> but was:<RUNNING>
Tests run: 150, Failures: 1, Errors: 0, Skipped: 0
```
it's reported in [ZEPPELIN-1857](https://issues.apache.org/jira/browse/ZEPPELIN-1857).
Merge if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1822: [ZEPPELIN-1789] Make exported data file name more expl...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1822
@AhyoungRyu Thanks~ LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1822: [ZEPPELIN-1789] Make exported data file name more expl...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1822
@Leemoonsoo Addressed your comment in [d7d0087](https://github.com/apache/zeppelin/pull/1822/commits/d7d00872859d8d4f91e11875bbcd8e1012c8e2a6). Please check if you have time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1822: [ZEPPELIN-1789] Make exported data file name more expl...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1822
@Leemoonsoo I've just updated as you said and the PR description as well. Please take a look :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1822: [ZEPPELIN-1789] Make exported data file name mo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1822
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1822: [ZEPPELIN-1789] Make exported data file name more expl...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1822
Thanks @AhyoungRyu for the improvement.
How about use [`dateFinished`](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/Job.java#L73) instead of current time in the file name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---