You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2025/10/04 02:11:19 UTC
[PR] feat(pipeline_options): add support for custom maven repository url [beam]
liferoad opened a new pull request, #36390:
URL: https://github.com/apache/beam/pull/36390
Add --maven_repository_url flag to SetupOptions to allow specifying custom Maven repository Modify JavaJarServer, JavaJarExpansionService and BeamJarExpansionService to use custom repository Update _resolve_expansion_service to pass maven_repository_url from pipeline options Add unit tests for maven_repository_url functionality
Fixes https://github.com/apache/beam/issues/36338
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pipeline_options): add support for custom maven repository url [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #36390:
URL: https://github.com/apache/beam/pull/36390#discussion_r2403666622
##########
sdks/python/apache_beam/transforms/managed.py:
##########
@@ -193,4 +212,18 @@ def _resolve_expansion_service(
raise ValueError(
"No expansion service was specified and could not find a "
f"default expansion service for {transform_name}: '{identifier}'.")
- return BeamJarExpansionService(gradle_target)
+
+ # Extract maven_repository_url and user_agent from pipeline options if
+ # available
+ maven_repository_url = None
+ user_agent = None
+ if pipeline_options:
+ from apache_beam.options import pipeline_options as po
+ setup_options = pipeline_options.view_as(po.SetupOptions)
+ maven_repository_url = setup_options.maven_repository_url
+ user_agent = setup_options.user_agent
+
+ return BeamJarExpansionService(
Review Comment:
I think we need to pass user_agent and maven_repository_url here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pipeline_options): add support for custom maven repository url [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #36390:
URL: https://github.com/apache/beam/pull/36390#issuecomment-3367767327
## Summary of Changes
Hello @liferoad, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the Apache Beam Python SDK by providing users with the flexibility to specify a custom Maven repository URL. This is particularly useful for environments requiring dependencies from private or alternative repositories, moving beyond the default Maven Central. The changes involve adding a new pipeline option and ensuring this option is correctly propagated and utilized by the internal services responsible for managing and expanding Java JARs.
### Highlights
* **New Pipeline Option**: Introduced a new `--maven_repository_url` flag within `SetupOptions` to allow users to specify a custom Maven repository URL for downloading JAR files, defaulting to Maven Central if not provided.
* **Maven Repository Integration**: Modified `JavaJarServer`, `JavaJarExpansionService`, and `BeamJarExpansionService` to accept and utilize the custom Maven repository URL when resolving and downloading JAR dependencies.
* **Pipeline Options Propagation**: Updated the `_resolve_expansion_service` function to extract the `maven_repository_url` from pipeline options and pass it down to the expansion services, ensuring the custom URL is used consistently.
* **Unit Tests**: Added comprehensive unit tests to verify the correct functionality and propagation of the `maven_repository_url` across the various components involved in JAR resolution and expansion.
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pipeline_options): add support for custom maven repository url [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #36390:
URL: https://github.com/apache/beam/pull/36390#discussion_r2417009334
##########
sdks/python/apache_beam/transforms/test_maven_repository_url.py:
##########
@@ -0,0 +1,224 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Unit tests for the maven_repository_url functionality."""
Review Comment:
Consider `maven_repository_url_test.py` per naming convention
##########
sdks/python/apache_beam/transforms/external.py:
##########
@@ -1040,7 +1040,8 @@ def __init__(
extra_args=None,
classpath=None,
append_args=None,
- user_agent=None):
+ user_agent=None,
+ maven_repository_url=None):
Review Comment:
consider update pydoc to add new parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pipeline_options): add support for custom maven repository url [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad merged PR #36390:
URL: https://github.com/apache/beam/pull/36390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pipeline_options): add support for custom maven repository url [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad closed pull request #36390: feat(pipeline_options): add support for custom maven repository url
URL: https://github.com/apache/beam/pull/36390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pipeline_options): add support for custom maven repository url [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #36390:
URL: https://github.com/apache/beam/pull/36390#issuecomment-3387872259
Failed workflows are not related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pipeline_options): add support for custom maven repository url [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36390:
URL: https://github.com/apache/beam/pull/36390#issuecomment-3367848999
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pipeline_options): add support for custom maven repository url [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #36390:
URL: https://github.com/apache/beam/pull/36390#discussion_r2417028959
##########
sdks/python/apache_beam/utils/subprocess_server.py:
##########
@@ -404,11 +405,12 @@ def path_to_beam_jar(
_LOGGER.info('Using pre-built snapshot at %s', local_path)
return local_path
- maven_repo = cls.MAVEN_CENTRAL_REPOSITORY
+ maven_repo = maven_repository_url or cls.MAVEN_CENTRAL_REPOSITORY
if 'rc' in version:
# Release candidate
version = version.split('rc')[0]
- maven_repo = cls.MAVEN_STAGING_REPOSITORY
+ if not maven_repository_url:
+ maven_repo = cls.MAVEN_STAGING_REPOSITORY
Review Comment:
not needed in this PR. With custom repository url we can enable `'.dev' in version:` branch below. May also need `maven_repository_url` to support a file system path (pass a local maven repo as pipeline option)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pipeline_options): add support for custom maven repository url [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #36390:
URL: https://github.com/apache/beam/pull/36390#issuecomment-3367775725
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/36390?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `20.75472%` with `84 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.18%. Comparing base ([`659cc4d`](https://app.codecov.io/gh/apache/beam/commit/659cc4dfbd69d667908c0c11a4b3c5aa5bcc0ced?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c4a1761`](https://app.codecov.io/gh/apache/beam/commit/c4a176136eae9c695db85a7abed2c53df7428457?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/beam/pull/36390?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...pache\_beam/transforms/test\_maven\_repository\_url.py](https://app.codecov.io/gh/apache/beam/pull/36390?src=pr&el=tree&filepath=sdks%2Fpython%2Fapache_beam%2Ftransforms%2Ftest_maven_repository_url.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy90ZXN0X21hdmVuX3JlcG9zaXRvcnlfdXJsLnB5) | 23.25% | [66 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/36390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [sdks/python/apache\_beam/transforms/managed.py](https://app.codecov.io/gh/apache/beam/pull/36390?src=pr&el=tree&filepath=sdks%2Fpython%2Fapache_beam%2Ftransforms%2Fmanaged.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9tYW5hZ2VkLnB5) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/36390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [sdks/python/apache\_beam/utils/subprocess\_server.py](https://app.codecov.io/gh/apache/beam/pull/36390?src=pr&el=tree&filepath=sdks%2Fpython%2Fapache_beam%2Futils%2Fsubprocess_server.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc3VicHJvY2Vzc19zZXJ2ZXIucHk=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/36390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [sdks/python/apache\_beam/transforms/external.py](https://app.codecov.io/gh/apache/beam/pull/36390?src=pr&el=tree&filepath=sdks%2Fpython%2Fapache_beam%2Ftransforms%2Fexternal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9leHRlcm5hbC5weQ==) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/36390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #36390 +/- ##
============================================
- Coverage 40.19% 40.18% -0.02%
Complexity 3386 3386
============================================
Files 1220 1221 +1
Lines 186217 186413 +196
Branches 3523 3523
============================================
+ Hits 74855 74913 +58
- Misses 108001 108139 +138
Partials 3361 3361
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/36390/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/36390/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.51% <20.75%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/36390?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(pipeline_options): add support for custom maven repository url [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad closed pull request #36390: feat(pipeline_options): add support for custom maven repository url
URL: https://github.com/apache/beam/pull/36390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org