You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Francesco Mari (JIRA)" <ji...@apache.org> on 2017/03/31 14:38:41 UTC

[jira] [Resolved] (OAK-6001) Remove unused code from FileStore and TarWriter

     [ https://issues.apache.org/jira/browse/OAK-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Mari resolved OAK-6001.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 1.7.0

Fixed at r1789696.

> Remove unused code from FileStore and TarWriter
> -----------------------------------------------
>
>                 Key: OAK-6001
>                 URL: https://issues.apache.org/jira/browse/OAK-6001
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: 1.7.0, 1.8
>
>
> {{FileStore.GarbageCollector#collectBulkReferences}} looks into the currently active {{TarWriter}} for references. At the time this method is invoked, the currently active {{TarWriter}} is always empty.
> Slightly before inspecting the {{TarWriter}}, {{FileStore#newWriter}} is called to flush the content of the current {{TarWriter}} and to create a fresh one. For this reason, inspecting the {{TarWriter}} in {{FileStore.GarbageCollector#collectBulkReferences}} is unnecessary - the graph of the {{TarWriter}} is always empty. Those lines of code can be safely removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)