You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Thomas Koch <th...@koch.ro> on 2011/09/12 20:15:29 UTC
Review Request: Watch recovery after disconnection when connection string
contains a prefix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1809/
-----------------------------------------------------------
Review request for zookeeper.
Summary
-------
- chroot is not a property of the ClientCnxn anymore but of the ZooKeeper class
- ClientCnxn has no reference to ZooKeeper anymore
- The WatchManager stores a reference to the chroot String with every watcher. It's not that much overhead since it's the same String instance all the time. The idea is, to prepare for additional patches that make it possible to use the same ClientCnxn with different ZooKeeper client instances that have different chroots.
This addresses bug ZOOKEEPER-961.
https://issues.apache.org/jira/browse/ZOOKEEPER-961
Diffs
-----
src/java/main/org/apache/zookeeper/ClientCnxn.java 78b2eb2
src/java/main/org/apache/zookeeper/ClientWatchManager.java d56374d
src/java/main/org/apache/zookeeper/ZooKeeper.java e82eaa0
src/java/main/org/apache/zookeeper/client/WatchManager.java PRE-CREATION
src/java/main/org/apache/zookeeper/client/WatchRegistration.java PRE-CREATION
src/java/test/org/apache/zookeeper/TestableZooKeeper.java f8344b6
src/java/test/org/apache/zookeeper/test/WatcherTest.java 90ec513
Diff: https://reviews.apache.org/r/1809/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: ZOOKEEPER-961 Watch recovery after disconnection when
connection string contains a prefix
Posted by Patrick Hunt <ph...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1809/
-----------------------------------------------------------
(Updated 2011-09-14 22:16:59.743604)
Review request for zookeeper.
Summary (updated)
-------
- chroot is not a property of the ClientCnxn anymore but of the ZooKeeper class
- ClientCnxn has no reference to ZooKeeper anymore
- The WatchManager stores a reference to the chroot String with every watcher. It's not that much overhead since it's the same String instance all the time. The idea is, to prepare for additional patches that make it possible to use the same ClientCnxn with different ZooKeeper client instances that have different chroots.
This addresses bug ZOOKEEPER-961.
https://issues.apache.org/jira/browse/ZOOKEEPER-961
Diffs
-----
src/java/main/org/apache/zookeeper/ClientCnxn.java 78b2eb2
src/java/main/org/apache/zookeeper/ClientWatchManager.java d56374d
src/java/main/org/apache/zookeeper/ZooKeeper.java e82eaa0
src/java/main/org/apache/zookeeper/client/WatchManager.java PRE-CREATION
src/java/main/org/apache/zookeeper/client/WatchRegistration.java PRE-CREATION
src/java/test/org/apache/zookeeper/TestableZooKeeper.java f8344b6
src/java/test/org/apache/zookeeper/test/WatcherTest.java 90ec513
Diff: https://reviews.apache.org/r/1809/diff
Testing
-------
Thanks,
Thomas