You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/12/20 11:31:55 UTC
[PR] RATIS-2216. Bump maven-shade-plugin to 3.6.0 [ratis]
adoroszlai opened a new pull request, #1191:
URL: https://github.com/apache/ratis/pull/1191
## What changes were proposed in this pull request?
1. Bump `maven-shade-plugin` from 3.2.4 to 3.6.0 (current latest), since versions before 3.5.3 may have non-reproducible output:
```bash
$ mvn artifact:check-buildplan
...
[INFO] --- artifact:3.5.3:check-buildplan (default-cli) @ ratis-examples ---
[ERROR] plugin with non-reproducible output: org.apache.maven.plugins:maven-shade-plugin:3.2.4, require minimum 3.5.3
```
2. Disable creation of `dependency-reduced-pom.xml` (affects the `ratis-examples` and `ratis-experiments` modules). These files are written to `dependencyReducedPomLocation`. The problem is that
> setting a value for this parameter with a directory other than `${basedir}` will change the value of `${basedir}` for all executions that come after the shade execution. This is often not what you want. This is considered an open issue with this plugin. ([source](https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#dependencyReducedPomLocation))
Using new version of `maven-shade-plugin` upgrades some other plugin dependencies, which changes the behavior of `maven-assembly-plugin`. The end result is that the assembly does not find `ratis-examples` and creates tarballs without that module. ([CI build fails](https://github.com/adoroszlai/ratis/actions/runs/12411463434/job/34649283536#step:6:16) when only `maven-shade-plugin` version is [bumped](https://github.com/adoroszlai/ratis/commit/95c787972a8f414df4f86e31ec22990de7447d0b).)
One possible workaround for the plugin issue is to use the default value of `${basedir}/dependency-reduced-pom.xml`. However, this creates the file in the module root dir, failing the `apache-rat-plugin` check on next build.
My assumption is that `ratis-examples` and `ratis-experiments` modules are not used as dependencies in third-party projects (which is where the dependency-reduced POM would be useful).
https://issues.apache.org/jira/browse/RATIS-2216
## How was this patch tested?
Built both current `master` and the patch. Checked `ratis-assembly` tarballs for differences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2216. Bump maven-shade-plugin to 3.6.0 [ratis]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1191:
URL: https://github.com/apache/ratis/pull/1191#issuecomment-2558138712
Thanks @szetszwo for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2216. Bump maven-shade-plugin to 3.6.0 [ratis]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #1191:
URL: https://github.com/apache/ratis/pull/1191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org