Re: [PR] WIP: Refactor and extract shared request handler logic from supervisor _handle_request methods [airflow]

["leeyspaul (via GitHub)" <gi...@apache.org>]

leeyspaul commented on code in PR #65624:
URL: https://github.com/apache/airflow/pull/65624#discussion_r3120704835


##########
task-sdk/src/airflow/sdk/execution_time/request_handlers.py:
##########
@@ -214,6 +216,15 @@ def handle_get_previous_dag_run(
     return resp, {}
 
 
+def handle_get_prev_successful_dag_run(
+    client: Client, subprocess_id: UUID
+) -> tuple[BaseModel | None, dict[str, bool]]:
+    """Fetch the previous successful dag run using the caller's current id."""
+    dagrun_resp = client.task_instances.get_previous_successful_dagrun(subprocess_id)

Review Comment:
   I noticed that this was from the parent `WatchSubprocess` class. I wasn't sure what to name this , even though it seems like a task_instance id I decided to be more general with subprocess_id here. Please let me know if this needs changing or better wording.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org