You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/28 06:15:10 UTC
[GitHub] codecov-io commented on issue #6046: WiP [table editor] allow
selecting physical table
codecov-io commented on issue #6046: WiP [table editor] allow selecting physical table
URL: https://github.com/apache/incubator-superset/pull/6046#issuecomment-442332597
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6046?src=pr&el=h1) Report
> Merging [#6046](https://codecov.io/gh/apache/incubator-superset/pull/6046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/71a713dcece69d11e08dfa9488416655442f441b?src=pr&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6046/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6046?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6046 +/- ##
==========================================
- Coverage 73.31% 73.08% -0.23%
==========================================
Files 67 67
Lines 9588 9592 +4
==========================================
- Hits 7029 7010 -19
- Misses 2559 2582 +23
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6046?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6046/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.96% <ø> (ø)` | :arrow_up: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/6046/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `96.96% <100%> (+0.81%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6046/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.49% <100%> (+0.21%)` | :arrow_up: |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/6046/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `83.18% <0%> (-11.51%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/6046/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.28% <0%> (-1.76%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6046/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.09% <0%> (-0.75%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6046/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.2% <0%> (-0.16%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/6046/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.51% <0%> (+0.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6046?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6046?src=pr&el=footer). Last update [71a713d...b565d41](https://codecov.io/gh/apache/incubator-superset/pull/6046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org