You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2017/10/27 16:38:32 UTC

[Bug 61682] New: StackOverflowError while executing HTTP/2 Server Push

https://bz.apache.org/bugzilla/show_bug.cgi?id=61682

            Bug ID: 61682
           Summary: StackOverflowError while executing HTTP/2 Server Push
           Product: Tomcat 9
           Version: 9.0.1
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Connectors
          Assignee: dev@tomcat.apache.org
          Reporter: chiptv@web.de
  Target Milestone: -----

While pushing some resources from the Server I received the following
StackOverflowError sometimes when refreshing my page (the resource failed to
load of course). 

```
Okt 27, 2017 3:10:26 PM org.apache.coyote.AbstractProtocol$ConnectionHandler
process
SEVERE: Error reading request, ignored
java.lang.StackOverflowError
        at
java.util.concurrent.ConcurrentHashMap$BaseIterator.<init>(ConcurrentHashMap.java:3391)
        at
java.util.concurrent.ConcurrentHashMap$KeyIterator.<init>(ConcurrentHashMap.java:3410)
        at
java.util.concurrent.ConcurrentHashMap$KeySetView.iterator(ConcurrentHashMap.java:4578)
        at java.util.Collections$SetFromMap.iterator(Collections.java:5462)
        at
org.apache.coyote.http2.AbstractStream.isDescendant(AbstractStream.java:69)
        at
org.apache.coyote.http2.AbstractStream.isDescendant(AbstractStream.java:70)
        at
org.apache.coyote.http2.AbstractStream.isDescendant(AbstractStream.java:70)
        at
org.apache.coyote.http2.AbstractStream.isDescendant(AbstractStream.java:70)
        at
org.apache.coyote.http2.AbstractStream.isDescendant(AbstractStream.java:70)
        at
org.apache.coyote.http2.AbstractStream.isDescendant(AbstractStream.java:70)
```

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 61682] StackOverflowError while executing HTTP/2 Server Push

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61682

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Thanks for the report.
Fixed in:
- trunk for 9.0.2 onwards
- 8.5.x for 8.5.24 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 61682] StackOverflowError while executing HTTP/2 Server Push

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61682

--- Comment #4 from Michael Ernst <ch...@web.de> ---
Hi Mark, thanks for fix. I had a look into the commit and I guess I wouldn't be
able to provide such a test case without having a deeper knowledge about the
code base.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 61682] StackOverflowError while executing HTTP/2 Server Push

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61682

Remy Maucherat <re...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
                 OS|                            |All

--- Comment #1 from Remy Maucherat <re...@apache.org> ---
Please provide a test case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 61682] StackOverflowError while executing HTTP/2 Server Push

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61682

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
I've managed to find a way to reproduce this. The logic for re-prioritising
streams doesn't always remove children from their old parent when they are
re-prioritised. With the right sequence of moves, you can generate circular
references.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org