You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "kishankavala (via GitHub)" <gi...@apache.org> on 2023/08/02 09:19:48 UTC

[GitHub] [cloudstack] kishankavala opened a new pull request, #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

kishankavala opened a new pull request, #7802:
URL: https://github.com/apache/cloudstack/pull/7802

   During deploy Vm failure, entries for nics will remain in DB. This will allow cleanup of any allocated nics.
   
   Steps to reproduce:
   
   Create 2 networks. One of the with a small IP range (/29 or /30)
   Deploy Vms with both networks until IPs in smaller network are exhausted
   Without fix, there won't be any nic entries for failed VM. UserVm Scavenger will not find any nics to cleanup.
   With the fix nic will be removed during Vm cleanup
   
   `DEBUG [o.a.c.e.o.NetworkOrchestrator] (UserVm-Scavenger-2:ctx-ddff4ea8) (logid:48d79c3c) Removed nic id=27`
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [X] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7802: Remove nic allocation txn during Vm deploy

Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663624145

   can we close this PR and continue with #7809 which is created for 4.18 branch ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663235405

   <b>[SF] Trillian test result (tid-7239)</b>
   Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 51729 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7802-t7239-kvm-rocky8.zip
   Smoke tests completed. 63 look OK, 18 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_start_failure | `Error` | 81.13 | test_deploy_vm.py
   test_deploy_vm_volume_creation_failure | `Error` | 80.91 | test_deploy_vm.py
   test_vm_ha | `Error` | 75.38 | test_vm_ha.py
   test_vm_sync | `Error` | 150.24 | test_vm_sync.py
   test_07_project_resources_account_delete | `Error` | 5.65 | test_projects.py
   test_08_cleanup_after_project_delete | `Error` | 7.53 | test_projects.py
   ContextSuite context=TestProjectResources>:teardown | `Error` | 9.79 | test_projects.py
   ContextSuite context=TestProjectSuspendActivate>:teardown | `Error` | 81.95 | test_projects.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:teardown | `Error` | 113.34 | test_affinity_groups_projects.py
   test_UpdateConfigParamWithScope | `Error` | 0.73 | test_global_settings.py
   test_03_deploy_vm_wrong_checksum | `Error` | 51.25 | test_templates.py
   test_create_pvlan_network | `Error` | 0.04 | test_pvlan.py
   test_03_user_role_dont_see_annotations | `Failure` | 2.93 | test_host_annotations.py
   test_03_RVR_Network_check_router_state | `Failure` | 126.28 | test_routers_network_ops.py
   test_02_deploy_vm_root_resize | `Failure` | 0.12 | test_deploy_vm_root_resize.py
   test_02_vpc_privategw_static_routes | `Failure` | 170.67 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 166.48 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 270.29 | test_privategw_acl.py
   test_02_unsecure_vm_migration | `Error` | 126.60 | test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 88.85 | test_vm_life_cycle.py
   test_03_download_attached_volume | `Error` | 19.68 | test_volumes.py
   test_04_delete_attached_volume | `Error` | 1.09 | test_volumes.py
   test_05_detach_volume | `Error` | 1.10 | test_volumes.py
   test_06_download_detached_volume | `Error` | 1.08 | test_volumes.py
   test_07_resize_fail | `Error` | 2.23 | test_volumes.py
   test_08_resize_volume | `Error` | 1.09 | test_volumes.py
   test_09_delete_detached_volume | `Error` | 19.71 | test_volumes.py
   test_11_attach_volume_with_unstarted_vm | `Error` | 2.37 | test_volumes.py
   ContextSuite context=TestVolumes>:teardown | `Error` | 265.73 | test_volumes.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 262.61 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 266.61 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 179.33 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 140.59 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 243.61 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 274.93 | test_vpc_redundant.py
   test_oobm_background_powerstate_sync | `Failure` | 21.75 | test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 32.99 | test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 18.74 | test_outofbandmanagement.py
   test_oobm_issue_power_off | `Error` | 19.76 | test_outofbandmanagement.py
   test_oobm_issue_power_on | `Error` | 19.76 | test_outofbandmanagement.py
   test_oobm_issue_power_reset | `Error` | 19.76 | test_outofbandmanagement.py
   test_oobm_issue_power_soft | `Error` | 19.73 | test_outofbandmanagement.py
   test_oobm_issue_power_status | `Error` | 18.73 | test_outofbandmanagement.py
   test_oobm_multiple_mgmt_server_ownership | `Failure` | 27.88 | test_outofbandmanagement.py
   test_oobm_zchange_password | `Error` | 7.38 | test_outofbandmanagement.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Failure` | 179.66 | test_host_maintenance.py
   test_hostha_kvm_host_degraded | `Error` | 8.86 | test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Error` | 9.88 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Error` | 9.86 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1661930356

   Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6628


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7802: Remove nic allocation txn during Vm deploy

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663654287

   Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6644


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1662115575

   @kiranchavala a [SF] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] codecov[bot] commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1661974065

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7802?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#7802](https://app.codecov.io/gh/apache/cloudstack/pull/7802?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5c7471a) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/0d9292c9ea168c358210796c4ec876438119cda0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0d9292c) will **increase** coverage by `0.00%`.
   > Report is 1 commits behind head on main.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #7802   +/-   ##
   =========================================
     Coverage     13.44%   13.44%           
   - Complexity     9397     9398    +1     
   =========================================
     Files          2747     2747           
     Lines        258844   258842    -2     
     Branches      40313    40311    -2     
   =========================================
   + Hits          34793    34799    +6     
   + Misses       219667   219661    -6     
   + Partials       4384     4382    -2     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/cloudstack/pull/7802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...tack/engine/orchestration/NetworkOrchestrator.java](https://app.codecov.io/gh/apache/cloudstack/pull/7802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL29yY2hlc3RyYXRpb24vTmV0d29ya09yY2hlc3RyYXRvci5qYXZh) | `6.06% <0.00%> (+<0.01%)` | :arrow_up: |
   
   ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7802/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7802: Remove nic allocation txn during Vm deploy

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663698126

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6645


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663298847

   @kiranchavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] kishankavala commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1661850926

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] kiranchavala commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1661966886

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1662084391

   @kishankavala should the newly allocated NICs be marked as removed, if/when the deploy failed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1661969323

   @kiranchavala a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663547749

   @kiranchavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1661851465

   @kishankavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] kishankavala commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1662188769

   > @kishankavala should the newly allocated NICs be marked as removed, if/when the deploy failed?
   
   @DaanHoogland Allocated nics are marked as removed by the UserVm Scavenger after deallocating them by the network provider.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663342054

   Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6636


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7802: Remove nic allocation txn during Vm deploy

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663565372

   @kiranchavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland closed pull request #7802: Remove nic allocation txn during Vm deploy

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7802: Remove nic allocation txn during Vm deploy
URL: https://github.com/apache/cloudstack/pull/7802


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] kiranchavala commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1662113608

   @blueorangutan test rocky8 kvm-rocky8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] kiranchavala commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663297986

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] kiranchavala commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663543569

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on pull request #7802: Remove nic allocation txn during Vm deploy. During Vm deploy failure,…

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663223915

   @kishankavala 
   thanks for the fixing. could you rebase with 4.18 branch ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] kiranchavala commented on pull request #7802: Remove nic allocation txn during Vm deploy

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7802:
URL: https://github.com/apache/cloudstack/pull/7802#issuecomment-1663563655

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org