You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/08/16 09:06:13 UTC
[jira] Created: (HARMONY-1206) [classlib][luni] Remove a never used
variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest.
[classlib][luni] Remove a never used variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest.
--------------------------------------------------------------------------------------------------------------
Key: HARMONY-1206
URL: http://issues.apache.org/jira/browse/HARMONY-1206
Project: Harmony
Issue Type: Test
Components: Classlib
Reporter: Andrew Zhang
Priority: Minor
Remove class variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest, which is never used in test and may cause unnecessary failures.
Consider following code in setUp():
if (addresses != null) {
try {
sameAsNetworkInterface1 = NetworkInterface.getByInetAddress((InetAddress) addresses.nextElement());
} catch (SocketException e) {
}
}
Notice that addresses.nextElement() may throw exception if addresses is empty (but not null).
I'll upload a patch to remove these unnecessary code soon.
Thanks!
Best regards,
Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1206) [classlib][luni] Remove a never used
variable "sameAsNetworkInterface1" in
tests.api.java.net.MulticastSocketTest.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1206?page=all ]
Paulex Yang closed HARMONY-1206.
--------------------------------
Verified by Andrew.
> [classlib][luni] Remove a never used variable "sameAsNetworkInterface1" in tests.api.java.net.MulticastSocketTest.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1206
> URL: http://issues.apache.org/jira/browse/HARMONY-1206
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony-1206.diff
>
>
> Remove class variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest, which is never used in test and may cause unnecessary failures.
> Consider following code in setUp():
> if (addresses != null) {
> try {
> sameAsNetworkInterface1 = NetworkInterface.getByInetAddress((InetAddress) addresses.nextElement());
> } catch (SocketException e) {
> }
> }
> Notice that addresses.nextElement() may throw exception if addresses is empty (but not null).
> I'll upload a patch to remove these unnecessary code soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1206) [classlib][luni] Remove a never used
variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1206?page=all ]
Andrew Zhang updated HARMONY-1206:
----------------------------------
Attachment: Harmony-1206.diff
Hi,
Would you please try my patch?
Thanks!
Best regards,
Andrew
> [classlib][luni] Remove a never used variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest.
> --------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1206
> URL: http://issues.apache.org/jira/browse/HARMONY-1206
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Priority: Minor
> Attachments: Harmony-1206.diff
>
>
> Remove class variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest, which is never used in test and may cause unnecessary failures.
> Consider following code in setUp():
> if (addresses != null) {
> try {
> sameAsNetworkInterface1 = NetworkInterface.getByInetAddress((InetAddress) addresses.nextElement());
> } catch (SocketException e) {
> }
> }
> Notice that addresses.nextElement() may throw exception if addresses is empty (but not null).
> I'll upload a patch to remove these unnecessary code soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1206) [classlib][luni] Remove a never
used variable "sameAsNetworkInterface1" in
tests.api.java.net.MulticastSocketTest.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1206?page=all ]
Paulex Yang resolved HARMONY-1206.
----------------------------------
Resolution: Fixed
Andrew, patch applied at revision r432181, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [classlib][luni] Remove a never used variable "sameAsNetworkInterface1" in tests.api.java.net.MulticastSocketTest.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1206
> URL: http://issues.apache.org/jira/browse/HARMONY-1206
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony-1206.diff
>
>
> Remove class variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest, which is never used in test and may cause unnecessary failures.
> Consider following code in setUp():
> if (addresses != null) {
> try {
> sameAsNetworkInterface1 = NetworkInterface.getByInetAddress((InetAddress) addresses.nextElement());
> } catch (SocketException e) {
> }
> }
> Notice that addresses.nextElement() may throw exception if addresses is empty (but not null).
> I'll upload a patch to remove these unnecessary code soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1206) [classlib][luni] Remove a never
used variable "MulticastSocketTest" in
tests.api.java.net.MulticastSocketTest.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1206?page=comments#action_12428343 ]
Andrew Zhang commented on HARMONY-1206:
---------------------------------------
Ah... Sorry for my type mistake in the JIRA subject. I mean "sameAsNetworkInterface1", not "MulticastSocketTest".
Thanks!
Best regards,
Andrew
> [classlib][luni] Remove a never used variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest.
> --------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1206
> URL: http://issues.apache.org/jira/browse/HARMONY-1206
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Priority: Minor
> Attachments: Harmony-1206.diff
>
>
> Remove class variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest, which is never used in test and may cause unnecessary failures.
> Consider following code in setUp():
> if (addresses != null) {
> try {
> sameAsNetworkInterface1 = NetworkInterface.getByInetAddress((InetAddress) addresses.nextElement());
> } catch (SocketException e) {
> }
> }
> Notice that addresses.nextElement() may throw exception if addresses is empty (but not null).
> I'll upload a patch to remove these unnecessary code soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1206) [classlib][luni] Remove a never used
variable "sameAsNetworkInterface1" in
tests.api.java.net.MulticastSocketTest.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1206?page=all ]
Paulex Yang updated HARMONY-1206:
---------------------------------
Summary: [classlib][luni] Remove a never used variable "sameAsNetworkInterface1" in tests.api.java.net.MulticastSocketTest. (was: [classlib][luni] Remove a never used variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest.)
fix the subject based on Andrew's comment
> [classlib][luni] Remove a never used variable "sameAsNetworkInterface1" in tests.api.java.net.MulticastSocketTest.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1206
> URL: http://issues.apache.org/jira/browse/HARMONY-1206
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony-1206.diff
>
>
> Remove class variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest, which is never used in test and may cause unnecessary failures.
> Consider following code in setUp():
> if (addresses != null) {
> try {
> sameAsNetworkInterface1 = NetworkInterface.getByInetAddress((InetAddress) addresses.nextElement());
> } catch (SocketException e) {
> }
> }
> Notice that addresses.nextElement() may throw exception if addresses is empty (but not null).
> I'll upload a patch to remove these unnecessary code soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1206) [classlib][luni] Remove a never
used variable "sameAsNetworkInterface1" in
tests.api.java.net.MulticastSocketTest.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1206?page=comments#action_12428609 ]
Andrew Zhang commented on HARMONY-1206:
---------------------------------------
Hi Paulex,
The fix looks fine, thanks!
Best regards,
Andrew
> [classlib][luni] Remove a never used variable "sameAsNetworkInterface1" in tests.api.java.net.MulticastSocketTest.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1206
> URL: http://issues.apache.org/jira/browse/HARMONY-1206
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony-1206.diff
>
>
> Remove class variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest, which is never used in test and may cause unnecessary failures.
> Consider following code in setUp():
> if (addresses != null) {
> try {
> sameAsNetworkInterface1 = NetworkInterface.getByInetAddress((InetAddress) addresses.nextElement());
> } catch (SocketException e) {
> }
> }
> Notice that addresses.nextElement() may throw exception if addresses is empty (but not null).
> I'll upload a patch to remove these unnecessary code soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1206) [classlib][luni] Remove a never
used variable "MulticastSocketTest" in
tests.api.java.net.MulticastSocketTest.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1206?page=all ]
Paulex Yang reassigned HARMONY-1206:
------------------------------------
Assignee: Paulex Yang
> [classlib][luni] Remove a never used variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest.
> --------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1206
> URL: http://issues.apache.org/jira/browse/HARMONY-1206
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony-1206.diff
>
>
> Remove class variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest, which is never used in test and may cause unnecessary failures.
> Consider following code in setUp():
> if (addresses != null) {
> try {
> sameAsNetworkInterface1 = NetworkInterface.getByInetAddress((InetAddress) addresses.nextElement());
> } catch (SocketException e) {
> }
> }
> Notice that addresses.nextElement() may throw exception if addresses is empty (but not null).
> I'll upload a patch to remove these unnecessary code soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira