You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/03/19 21:14:54 UTC
Review Request 19420: log4j configs to be applied after Ambari upgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
Bugs: AMBARI-5147
https://issues.apache.org/jira/browse/AMBARI-5147
Repository: ambari
Description
-------
As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
Proposals:
1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java eb253a4
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java b95a8bf
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
Diff: https://reviews.apache.org/r/19420/diff/
Testing
-------
Thanks,
Dmytro Sen
Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On March 19, 2014, 8:20 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java, line 475
> > <https://reviews.apache.org/r/19420/diff/1/?file=528404#file528404line475>
> >
> > Can you provide more info why can't the Criteria Builder cannot be used here. Generally, it would become easier to maintain if done in one place.
I was able to add ClusterConfigMapping's using ClusterDAO.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/#review37790
-----------------------------------------------------------
On March 20, 2014, 4:22 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19420/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 4:22 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-5147
> https://issues.apache.org/jira/browse/AMBARI-5147
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
> Proposals:
> 1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 3c1ad47
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java af2b247
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
>
> Diff: https://reviews.apache.org/r/19420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/#review37790
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java
<https://reviews.apache.org/r/19420/#comment69515>
Can you provide more info why can't the Criteria Builder cannot be used here. Generally, it would become easier to maintain if done in one place.
- Sid Wagle
On March 19, 2014, 8:14 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19420/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 8:14 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-5147
> https://issues.apache.org/jira/browse/AMBARI-5147
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
> Proposals:
> 1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java eb253a4
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java b95a8bf
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
>
> Diff: https://reviews.apache.org/r/19420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On March 19, 2014, 9:05 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java, line 593
> > <https://reviews.apache.org/r/19420/diff/1/?file=528404#file528404line593>
> >
> > Will this add all missing configs? Unless I misunderstood the patch.
> >
> > I think the scope of the JIRA is to add only the missing log4j configs. I think its risky to add all configs that are missing. User may not have deployed hbase/oozie and will get those configs as well.
These are the ones that may be missing. We also should add the "*log4j*" config only if the corresponding service is present. E.g. install hive-exec-log4j and hive-log4j only if HIVE service is present.
./1.3.2/services/HBASE/configuration/hbase-log4j.xml
./1.3.2/services/HDFS/configuration/hdfs-log4j.xml
./1.3.2/services/HIVE/configuration/hive-exec-log4j.xml
./1.3.2/services/HIVE/configuration/hive-log4j.xml
./1.3.2/services/MAPREDUCE/configuration/mapreduce-log4j.xml
./1.3.2/services/OOZIE/configuration/oozie-log4j.xml
./1.3.2/services/PIG/configuration/pig-log4j.xml
./1.3.2/services/ZOOKEEPER/configuration/zookeeper-log4j.xml
./2.0.6/services/HBASE/configuration/hbase-log4j.xml
./2.0.6/services/HDFS/configuration/hdfs-log4j.xml
./2.0.6/services/HIVE/configuration/hive-exec-log4j.xml
./2.0.6/services/HIVE/configuration/hive-log4j.xml
./2.0.6/services/OOZIE/configuration/oozie-log4j.xml
./2.0.6/services/PIG/configuration/pig-log4j.xml
./2.0.6/services/YARN/configuration/yarn-log4j.xml
./2.0.6/services/ZOOKEEPER/configuration/zookeeper-log4j.xml
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/#review37795
-----------------------------------------------------------
On March 19, 2014, 8:14 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19420/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 8:14 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-5147
> https://issues.apache.org/jira/browse/AMBARI-5147
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
> Proposals:
> 1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java eb253a4
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java b95a8bf
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
>
> Diff: https://reviews.apache.org/r/19420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On March 19, 2014, 9:05 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java, line 593
> > <https://reviews.apache.org/r/19420/diff/1/?file=528404#file528404line593>
> >
> > Will this add all missing configs? Unless I misunderstood the patch.
> >
> > I think the scope of the JIRA is to add only the missing log4j configs. I think its risky to add all configs that are missing. User may not have deployed hbase/oozie and will get those configs as well.
>
> Sumit Mohanty wrote:
> These are the ones that may be missing. We also should add the "*log4j*" config only if the corresponding service is present. E.g. install hive-exec-log4j and hive-log4j only if HIVE service is present.
> ./1.3.2/services/HBASE/configuration/hbase-log4j.xml
> ./1.3.2/services/HDFS/configuration/hdfs-log4j.xml
> ./1.3.2/services/HIVE/configuration/hive-exec-log4j.xml
> ./1.3.2/services/HIVE/configuration/hive-log4j.xml
> ./1.3.2/services/MAPREDUCE/configuration/mapreduce-log4j.xml
> ./1.3.2/services/OOZIE/configuration/oozie-log4j.xml
> ./1.3.2/services/PIG/configuration/pig-log4j.xml
> ./1.3.2/services/ZOOKEEPER/configuration/zookeeper-log4j.xml
> ./2.0.6/services/HBASE/configuration/hbase-log4j.xml
> ./2.0.6/services/HDFS/configuration/hdfs-log4j.xml
> ./2.0.6/services/HIVE/configuration/hive-exec-log4j.xml
> ./2.0.6/services/HIVE/configuration/hive-log4j.xml
> ./2.0.6/services/OOZIE/configuration/oozie-log4j.xml
> ./2.0.6/services/PIG/configuration/pig-log4j.xml
> ./2.0.6/services/YARN/configuration/yarn-log4j.xml
> ./2.0.6/services/ZOOKEEPER/configuration/zookeeper-log4j.xml
Fixed in the new patch by config-type.contains("log4j"). Configs are added only for installed services.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/#review37795
-----------------------------------------------------------
On March 20, 2014, 4:22 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19420/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 4:22 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-5147
> https://issues.apache.org/jira/browse/AMBARI-5147
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
> Proposals:
> 1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 3c1ad47
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java af2b247
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
>
> Diff: https://reviews.apache.org/r/19420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/#review37795
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java
<https://reviews.apache.org/r/19420/#comment69523>
Will this add all missing configs? Unless I misunderstood the patch.
I think the scope of the JIRA is to add only the missing log4j configs. I think its risky to add all configs that are missing. User may not have deployed hbase/oozie and will get those configs as well.
- Sumit Mohanty
On March 19, 2014, 8:14 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19420/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 8:14 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-5147
> https://issues.apache.org/jira/browse/AMBARI-5147
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
> Proposals:
> 1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java eb253a4
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java b95a8bf
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
>
> Diff: https://reviews.apache.org/r/19420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On March 19, 2014, 8:50 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java, line 719
> > <https://reviews.apache.org/r/19420/diff/1/?file=528404#file528404line719>
> >
> > Why don't we hard code the types for which clusterconfigmapping entries need to be created?
> >
> > If you run upgrade twice what will happen?
> > - add missing config will skip the configs and this is expected
> > - will this mapping query also skip adding clusterconfigmapping entries?
The new patch correctly handles multiple run of "ambari-server upgrade" command.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/#review37794
-----------------------------------------------------------
On March 20, 2014, 4:22 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19420/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 4:22 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-5147
> https://issues.apache.org/jira/browse/AMBARI-5147
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
> Proposals:
> 1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 3c1ad47
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java af2b247
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
>
> Diff: https://reviews.apache.org/r/19420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/#review37794
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java
<https://reviews.apache.org/r/19420/#comment69521>
Why don't we hard code the types for which clusterconfigmapping entries need to be created?
If you run upgrade twice what will happen?
- add missing config will skip the configs and this is expected
- will this mapping query also skip adding clusterconfigmapping entries?
- Sumit Mohanty
On March 19, 2014, 8:14 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19420/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 8:14 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-5147
> https://issues.apache.org/jira/browse/AMBARI-5147
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
> Proposals:
> 1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java eb253a4
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java b95a8bf
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
>
> Diff: https://reviews.apache.org/r/19420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/
-----------------------------------------------------------
(Updated March 20, 2014, 4:51 p.m.)
Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-5147
https://issues.apache.org/jira/browse/AMBARI-5147
Repository: ambari
Description
-------
As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
Proposals:
1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 3c1ad47
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java af2b247
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
Diff: https://reviews.apache.org/r/19420/diff/
Testing (updated)
-------
OK
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [0.085s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.027s]
[INFO] Ambari Web ........................................ SUCCESS [8.411s]
[INFO] Ambari Views ...................................... SUCCESS [1.847s]
[INFO] Ambari Server ..................................... SUCCESS [11:49.210s]
[INFO] Ambari Agent ...................................... SUCCESS [15.636s]
[INFO] Ambari Client ..................................... SUCCESS [0.708s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Dmytro Sen
Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/#review37905
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On March 20, 2014, 4:37 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19420/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 4:37 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-5147
> https://issues.apache.org/jira/browse/AMBARI-5147
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
> Proposals:
> 1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 3c1ad47
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java af2b247
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
>
> Diff: https://reviews.apache.org/r/19420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/
-----------------------------------------------------------
(Updated March 20, 2014, 4:37 p.m.)
Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-5147
https://issues.apache.org/jira/browse/AMBARI-5147
Repository: ambari
Description
-------
As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
Proposals:
1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 3c1ad47
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java af2b247
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
Diff: https://reviews.apache.org/r/19420/diff/
Testing
-------
Thanks,
Dmytro Sen
Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/
-----------------------------------------------------------
(Updated March 20, 2014, 4:22 p.m.)
Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
Changes
-------
Uploaded new patch. It uses no native SQL and adds only *-log4j configs.
Bugs: AMBARI-5147
https://issues.apache.org/jira/browse/AMBARI-5147
Repository: ambari
Description
-------
As a part of ambari upgrade, customized log4j properties for HDP services must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.).
Proposals:
1. "ambari-server upgrade" command runs separate java software, which connects to the Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties files, for instance, copy them to predefined directory on ambari-server node.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java b26091a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 55697dc
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 3c1ad47
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java af2b247
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae
Diff: https://reviews.apache.org/r/19420/diff/
Testing
-------
Thanks,
Dmytro Sen