[GitHub] [unomi] sergehuber commented on a change in pull request #148: UNOMI-327 Various quality issues

[GitBox <gi...@apache.org>]

sergehuber commented on a change in pull request #148:
URL: https://github.com/apache/unomi/pull/148#discussion_r414483444



##########
File path: persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
##########
@@ -688,6 +690,12 @@ public T execute(Object... args) throws Exception {
                             return null;
                         }
                     }
+                } catch (ElasticsearchStatusException ese) {
+                    if (ese.status().equals(RestStatus.NOT_FOUND)) {
+                        // this can happen if we are just testing the existence of the item, it is not always an error.
+                        return null;
+                    }
+                    throw new Exception("Error loading itemType=" + clazz.getName() + " itemId=" + itemId, ese);

Review comment:
       I'm sorry but this suggestion is not correct because clazz is an argument to the method, not a typo :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org