You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2016/12/28 10:38:16 UTC
Review Request 55070: UI should validate Ranger user password be more
than 8 chars
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55070/
-----------------------------------------------------------
Review request for Ambari and Andrii Tkach.
Bugs: AMBARI-19307
https://issues.apache.org/jira/browse/AMBARI-19307
Repository: ambari
Description
-------
During Ranger deploy, on config tab, user should set password for admin user. UI do not validate password to be more than 8 characters. As the result, when we will try to create it in Ranger, this user will not be valid (you can't use this name/password to enter Ranger UI). Related alert will show critical message. So, i think it should be fixed.
Diffs
-----
ambari-web/app/messages.js e9d117a
ambari-web/app/utils/config.js cd09e14
ambari-web/test/models/configs/objects/service_config_property_test.js ef0bd61
Diff: https://reviews.apache.org/r/55070/diff/
Testing
-------
19984 tests complete (27 seconds)
153 tests pending
Thanks,
Oleg Nechiporenko
Re: Review Request 55070: UI should validate Ranger user password be
more than 8 chars
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55070/#review160220
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On Dec. 28, 2016, 10:38 a.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55070/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2016, 10:38 a.m.)
>
>
> Review request for Ambari and Andrii Tkach.
>
>
> Bugs: AMBARI-19307
> https://issues.apache.org/jira/browse/AMBARI-19307
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During Ranger deploy, on config tab, user should set password for admin user. UI do not validate password to be more than 8 characters. As the result, when we will try to create it in Ranger, this user will not be valid (you can't use this name/password to enter Ranger UI). Related alert will show critical message. So, i think it should be fixed.
>
>
> Diffs
> -----
>
> ambari-web/app/messages.js e9d117a
> ambari-web/app/utils/config.js cd09e14
> ambari-web/test/models/configs/objects/service_config_property_test.js ef0bd61
>
> Diff: https://reviews.apache.org/r/55070/diff/
>
>
> Testing
> -------
>
> 19984 tests complete (27 seconds)
> 153 tests pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>