[GitHub] [airflow] dimon222 commented on a change in pull request #19725: Adjust built-in base_aws methods to avoid Deprecation warnings

[GitBox <gi...@apache.org>]

dimon222 commented on a change in pull request #19725:
URL: https://github.com/apache/airflow/pull/19725#discussion_r755403109



##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -184,7 +184,8 @@ def get_iam_token(self, conn: Connection) -> Tuple[str, str, int]:
             # Pull the custer-identifier from the beginning of the Redshift URL
             # ex. my-cluster.ccdre4hpd39h.us-east-1.redshift.amazonaws.com returns my-cluster
             cluster_identifier = conn.extra_dejson.get('cluster-identifier', conn.host.split('.')[0])
-            client = aws_hook.get_client_type('redshift')
+            session, endpoint_url = aws_hook._get_credentials()
+            client = session.client('redshift', endpoint_url=endpoint_url, config=aws_hook.config, verify=aws_hook.verify)

Review comment:
       get_client_type barks with Deprecation on any first argument ever passed. This and glue are among other references that I found in IDE just now. I said I haven't investigated entire codebase for similar gaps earlier...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org