You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Wencong Liu <li...@163.com> on 2023/07/21 02:51:53 UTC
[DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()
Hi devs,
I would like to start a discussion on FLIP-343: Remove parameter in
WindowAssigner#getDefaultTrigger() [1].
The method getDefaultTrigger() in WindowAssigner takes a StreamExecutionEnvironment
parameter, but this parameter is not actually used for any subclasses of WindowAssigner.
Therefore, it is unnecessary to include this parameter.
As such I propose to remove the StreamExecutionEnvironment field from
WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env).
Looking forward to your feedback.
[1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263425229
Best regards,
Wencong Liu
Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()
Posted by Junrui Lee <jr...@gmail.com>.
+1
Best,
Junrui
weijie guo <gu...@gmail.com> 于2023年7月24日周一 10:25写道：
> +1 for this.
>
> Best regards,
>
> Weijie
>
>
> liu ron <ro...@gmail.com> 于2023年7月24日周一 09:58写道：
>
> > +1
> >
> > Best,
> > Ron
> >
> > Yuxin Tan <ta...@gmail.com> 于2023年7月21日周五 16:21写道：
> >
> > > +1
> > >
> > > Best,
> > > Yuxin
> > >
> > >
> > > Jing Ge <ji...@ververica.com.invalid> 于2023年7月21日周五 15:41写道：
> > >
> > > > +1
> > > >
> > > > NIT: the release in the FLIP is still empty, it should be 2.0
> > > >
> > > > Best regards,
> > > > Jing
> > > >
> > > > On Fri, Jul 21, 2023 at 6:03 AM Xintong Song <to...@gmail.com>
> > > > wrote:
> > > >
> > > > > +1
> > > > >
> > > > > Best,
> > > > >
> > > > > Xintong
> > > > >
> > > > >
> > > > >
> > > > > On Fri, Jul 21, 2023 at 10:53 AM Wencong Liu <liuwenclever@163.com
> >
> > > > wrote:
> > > > >
> > > > > > Hi devs,
> > > > > >
> > > > > > I would like to start a discussion on FLIP-343: Remove parameter
> in
> > > > > > WindowAssigner#getDefaultTrigger() [1].
> > > > > >
> > > > > >
> > > > > > The method getDefaultTrigger() in WindowAssigner takes a
> > > > > > StreamExecutionEnvironment
> > > > > > parameter, but this parameter is not actually used for any
> > subclasses
> > > > of
> > > > > > WindowAssigner.
> > > > > > Therefore, it is unnecessary to include this parameter.
> > > > > > As such I propose to remove the StreamExecutionEnvironment field
> > from
> > > > > > WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env).
> > > > > > Looking forward to your feedback.
> > > > > > [1]
> > > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263425229
> > > > > > Best regards,
> > > > > >
> > > > > >
> > > > > > Wencong Liu
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()
Posted by weijie guo <gu...@gmail.com>.
+1 for this.
Best regards,
Weijie
liu ron <ro...@gmail.com> 于2023年7月24日周一 09:58写道：
> +1
>
> Best,
> Ron
>
> Yuxin Tan <ta...@gmail.com> 于2023年7月21日周五 16:21写道：
>
> > +1
> >
> > Best,
> > Yuxin
> >
> >
> > Jing Ge <ji...@ververica.com.invalid> 于2023年7月21日周五 15:41写道：
> >
> > > +1
> > >
> > > NIT: the release in the FLIP is still empty, it should be 2.0
> > >
> > > Best regards,
> > > Jing
> > >
> > > On Fri, Jul 21, 2023 at 6:03 AM Xintong Song <to...@gmail.com>
> > > wrote:
> > >
> > > > +1
> > > >
> > > > Best,
> > > >
> > > > Xintong
> > > >
> > > >
> > > >
> > > > On Fri, Jul 21, 2023 at 10:53 AM Wencong Liu <li...@163.com>
> > > wrote:
> > > >
> > > > > Hi devs,
> > > > >
> > > > > I would like to start a discussion on FLIP-343: Remove parameter in
> > > > > WindowAssigner#getDefaultTrigger() [1].
> > > > >
> > > > >
> > > > > The method getDefaultTrigger() in WindowAssigner takes a
> > > > > StreamExecutionEnvironment
> > > > > parameter, but this parameter is not actually used for any
> subclasses
> > > of
> > > > > WindowAssigner.
> > > > > Therefore, it is unnecessary to include this parameter.
> > > > > As such I propose to remove the StreamExecutionEnvironment field
> from
> > > > > WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env).
> > > > > Looking forward to your feedback.
> > > > > [1]
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263425229
> > > > > Best regards,
> > > > >
> > > > >
> > > > > Wencong Liu
> > > >
> > >
> >
>
Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()
Posted by liu ron <ro...@gmail.com>.
+1
Best,
Ron
Yuxin Tan <ta...@gmail.com> 于2023年7月21日周五 16:21写道：
> +1
>
> Best,
> Yuxin
>
>
> Jing Ge <ji...@ververica.com.invalid> 于2023年7月21日周五 15:41写道：
>
> > +1
> >
> > NIT: the release in the FLIP is still empty, it should be 2.0
> >
> > Best regards,
> > Jing
> >
> > On Fri, Jul 21, 2023 at 6:03 AM Xintong Song <to...@gmail.com>
> > wrote:
> >
> > > +1
> > >
> > > Best,
> > >
> > > Xintong
> > >
> > >
> > >
> > > On Fri, Jul 21, 2023 at 10:53 AM Wencong Liu <li...@163.com>
> > wrote:
> > >
> > > > Hi devs,
> > > >
> > > > I would like to start a discussion on FLIP-343: Remove parameter in
> > > > WindowAssigner#getDefaultTrigger() [1].
> > > >
> > > >
> > > > The method getDefaultTrigger() in WindowAssigner takes a
> > > > StreamExecutionEnvironment
> > > > parameter, but this parameter is not actually used for any subclasses
> > of
> > > > WindowAssigner.
> > > > Therefore, it is unnecessary to include this parameter.
> > > > As such I propose to remove the StreamExecutionEnvironment field from
> > > > WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env).
> > > > Looking forward to your feedback.
> > > > [1]
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263425229
> > > > Best regards,
> > > >
> > > >
> > > > Wencong Liu
> > >
> >
>
Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()
Posted by Yuxin Tan <ta...@gmail.com>.
+1
Best,
Yuxin
Jing Ge <ji...@ververica.com.invalid> 于2023年7月21日周五 15:41写道：
> +1
>
> NIT: the release in the FLIP is still empty, it should be 2.0
>
> Best regards,
> Jing
>
> On Fri, Jul 21, 2023 at 6:03 AM Xintong Song <to...@gmail.com>
> wrote:
>
> > +1
> >
> > Best,
> >
> > Xintong
> >
> >
> >
> > On Fri, Jul 21, 2023 at 10:53 AM Wencong Liu <li...@163.com>
> wrote:
> >
> > > Hi devs,
> > >
> > > I would like to start a discussion on FLIP-343: Remove parameter in
> > > WindowAssigner#getDefaultTrigger() [1].
> > >
> > >
> > > The method getDefaultTrigger() in WindowAssigner takes a
> > > StreamExecutionEnvironment
> > > parameter, but this parameter is not actually used for any subclasses
> of
> > > WindowAssigner.
> > > Therefore, it is unnecessary to include this parameter.
> > > As such I propose to remove the StreamExecutionEnvironment field from
> > > WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env).
> > > Looking forward to your feedback.
> > > [1]
> > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263425229
> > > Best regards,
> > >
> > >
> > > Wencong Liu
> >
>
Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()
Posted by Jing Ge <ji...@ververica.com.INVALID>.
+1
NIT: the release in the FLIP is still empty, it should be 2.0
Best regards,
Jing
On Fri, Jul 21, 2023 at 6:03 AM Xintong Song <to...@gmail.com> wrote:
> +1
>
> Best,
>
> Xintong
>
>
>
> On Fri, Jul 21, 2023 at 10:53 AM Wencong Liu <li...@163.com> wrote:
>
> > Hi devs,
> >
> > I would like to start a discussion on FLIP-343: Remove parameter in
> > WindowAssigner#getDefaultTrigger() [1].
> >
> >
> > The method getDefaultTrigger() in WindowAssigner takes a
> > StreamExecutionEnvironment
> > parameter, but this parameter is not actually used for any subclasses of
> > WindowAssigner.
> > Therefore, it is unnecessary to include this parameter.
> > As such I propose to remove the StreamExecutionEnvironment field from
> > WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env).
> > Looking forward to your feedback.
> > [1]
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263425229
> > Best regards,
> >
> >
> > Wencong Liu
>
Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()
Posted by Xintong Song <to...@gmail.com>.
+1
Best,
Xintong
On Fri, Jul 21, 2023 at 10:53 AM Wencong Liu <li...@163.com> wrote:
> Hi devs,
>
> I would like to start a discussion on FLIP-343: Remove parameter in
> WindowAssigner#getDefaultTrigger() [1].
>
>
> The method getDefaultTrigger() in WindowAssigner takes a
> StreamExecutionEnvironment
> parameter, but this parameter is not actually used for any subclasses of
> WindowAssigner.
> Therefore, it is unnecessary to include this parameter.
> As such I propose to remove the StreamExecutionEnvironment field from
> WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env).
> Looking forward to your feedback.
> [1]
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263425229
> Best regards,
>
>
> Wencong Liu