[GitHub] [netbeans] tmysik commented on a change in pull request #2678: [NETBEANS-5244] Add the project settings for XML configuration of phpDocumentor

[GitBox <gi...@apache.org>]

tmysik commented on a change in pull request #2678:
URL: https://github.com/apache/netbeans/pull/2678#discussion_r559086510



##########
File path: php/php.phpdoc/src/org/netbeans/modules/php/phpdoc/PhpDocScript.java
##########
@@ -145,13 +149,24 @@ private String sanitizePath(String path) {
         return path;
     }
 
-    private List<String> getParameters(String sanitizedPhpDocTarget, PhpModule phpModule) {
+    private List<String> getAllParameters(String sanitizedPhpDocTarget, PhpModule phpModule) {
+        List<String> params = new ArrayList<>(getDefaultParameters(sanitizedPhpDocTarget, phpModule));
+        if (PhpDocPreferences.isConfigurationEnabled(phpModule)) {
+            String configurationPath = PhpDocPreferences.getPhpDocConfigurationPath(phpModule);
+            if (!StringUtils.isEmpty(configurationPath)) {
+                params.add(PARAM_CONFIG);
+                params.add(sanitizePath(PhpDocPreferences.getPhpDocConfigurationPath(phpModule)));

Review comment:
       If the path is incorrect, PhpDoc itself will complain, I guess, so we don't need to run the validator here. Or do we? :thinking: 
   
   AFAIR we validate project properties before each run and if they are incorrect, the Project Properties dialog is opened.
   
   @junichi11 @KacerCZ What do you think, guys?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists