You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/03/30 16:35:25 UTC
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request
#4573: Update Go to version 1.14
rawlinp commented on a change in pull request #4573: Update Go to version 1.14
URL: https://github.com/apache/trafficcontrol/pull/4573#discussion_r400332381
##########
File path: build/functions.sh
##########
@@ -206,7 +206,7 @@ function verify_and_set_go_version () {
go_version=`$g version | awk '{print $3}'`
- if [[ $go_version =~ go([1-9])\.([1-9]+) ]] && [[ ${BASH_REMATCH[1]} -ge 1 ]] && [[ ${BASH_REMATCH[2]} -ge 11 ]]; then
+ if [[ $go_version =~ go([1-9])\.([1-9]+) ]] && [[ ${BASH_REMATCH[1]} -ge 1 ]] && [[ ${BASH_REMATCH[2]} -ge 13 ]]; then
Review comment:
this should be `-ge 14` now right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services