You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tapestry.apache.org by Otho <ta...@googlemail.com> on 2010/03/22 11:58:35 UTC
[T5.2] Deprecated public API of RenderSupport removed without
replacements?
Hi all!
I migrated a project to Spring 3. To make it work with Tapestry I had to
upgrade to 5.2-Snapshot.
Now I use RenderSupport.addScript(String scriptSnippet) and
RenderSupport.addScriptLink(String) quite a lot.
Both of them are deprecated and removed but the latter doesn't have a direct
counterpart in the new JavascriptSupport service.
The JavascriptSupport.importJavaScriptLibrary(Asset asset) makes dynamically
building the script link tedious at least.
I think this is quite a breaking change of the public API for a lot of apps
which use RenderSupport.
Is this only a transitional effect due to the beta nature of 5.2, or are
these changes meant as final?
If it is meant as final: Wouldn't it be better to deprecate the methods in
RenderSupport but keep them in for compatibility with legacy apps and hint
at the new JavascriptSupport for future projects and remove the deprecated
API only at the next major version?
Regards,
Otho
Re: [T5.2] Deprecated public API of RenderSupport removed without
replacements?
Posted by Massimo Lusetti <ml...@gmail.com>.
On Tue, Mar 23, 2010 at 5:36 PM, Howard Lewis Ship <hl...@gmail.com> wrote:
> I think because I had built all the supporting APIs around Assets, not
> links. I'm sure there's a way to slip this back in.
It would be useful to people which need to integrate with legacy apps (as me)
Cheers
--
Massimo
http://meridio.blogspot.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org
Re: [T5.2] Deprecated public API of RenderSupport removed without
replacements?
Posted by Howard Lewis Ship <hl...@gmail.com>.
I think because I had built all the supporting APIs around Assets, not
links. I'm sure there's a way to slip this back in.
On Tue, Mar 23, 2010 at 1:53 AM, Massimo Lusetti <ml...@gmail.com> wrote:
> On Mon, Mar 22, 2010 at 11:31 PM, Otho <ta...@googlemail.com> wrote:
>
>> Issue entered as *TAP5-1068<https://issues.apache.org/jira/browse/TAP5-1068>
>> *
>>
>> In my case it is specifically a link to the Google maps API, where I have to
>> conditionally set the sensor parameter to true or false and later on maybe
>> even the API key depending on the user.
>>
>> It would be neat, if JavascriptSupport would support the functionality of
>> the old RenderSupport.addScriptLink(String)
>>
>> 2010/3/22 Howard Lewis Ship <hl...@gmail.com>
>>
>>> You are right this was sloppy on my part. Please add an issue and
>>> I'll put together a fix (which will have the ugliness of a new
>>> interface that starts with a deprecated method, but such is life).
>
> Yep, why you want to deprecate it?
>
> --
> Massimo
> http://meridio.blogspot.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: users-help@tapestry.apache.org
>
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org
Re: [T5.2] Deprecated public API of RenderSupport removed without
replacements?
Posted by Massimo Lusetti <ml...@gmail.com>.
On Mon, Mar 22, 2010 at 11:31 PM, Otho <ta...@googlemail.com> wrote:
> Issue entered as *TAP5-1068<https://issues.apache.org/jira/browse/TAP5-1068>
> *
>
> In my case it is specifically a link to the Google maps API, where I have to
> conditionally set the sensor parameter to true or false and later on maybe
> even the API key depending on the user.
>
> It would be neat, if JavascriptSupport would support the functionality of
> the old RenderSupport.addScriptLink(String)
>
> 2010/3/22 Howard Lewis Ship <hl...@gmail.com>
>
>> You are right this was sloppy on my part. Please add an issue and
>> I'll put together a fix (which will have the ugliness of a new
>> interface that starts with a deprecated method, but such is life).
Yep, why you want to deprecate it?
--
Massimo
http://meridio.blogspot.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org
Re: [T5.2] Deprecated public API of RenderSupport removed without
replacements?
Posted by Otho <ta...@googlemail.com>.
Issue entered as *TAP5-1068<https://issues.apache.org/jira/browse/TAP5-1068>
*
In my case it is specifically a link to the Google maps API, where I have to
conditionally set the sensor parameter to true or false and later on maybe
even the API key depending on the user.
It would be neat, if JavascriptSupport would support the functionality of
the old RenderSupport.addScriptLink(String)
2010/3/22 Howard Lewis Ship <hl...@gmail.com>
> You are right this was sloppy on my part. Please add an issue and
> I'll put together a fix (which will have the ugliness of a new
> interface that starts with a deprecated method, but such is life).
>
> On Mon, Mar 22, 2010 at 3:58 AM, Otho <ta...@googlemail.com> wrote:
> > Hi all!
> >
> > I migrated a project to Spring 3. To make it work with Tapestry I had to
> > upgrade to 5.2-Snapshot.
> >
> > Now I use RenderSupport.addScript(String scriptSnippet) and
> > RenderSupport.addScriptLink(String) quite a lot.
> > Both of them are deprecated and removed but the latter doesn't have a
> direct
> > counterpart in the new JavascriptSupport service.
> >
> > The JavascriptSupport.importJavaScriptLibrary(Asset asset) makes
> dynamically
> > building the script link tedious at least.
> >
> > I think this is quite a breaking change of the public API for a lot of
> apps
> > which use RenderSupport.
> >
> > Is this only a transitional effect due to the beta nature of 5.2, or are
> > these changes meant as final?
> >
> > If it is meant as final: Wouldn't it be better to deprecate the methods
> in
> > RenderSupport but keep them in for compatibility with legacy apps and
> hint
> > at the new JavascriptSupport for future projects and remove the
> deprecated
> > API only at the next major version?
> >
> > Regards,
> > Otho
> >
>
>
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: users-help@tapestry.apache.org
>
>
Re: [T5.2] Deprecated public API of RenderSupport removed without
replacements?
Posted by Howard Lewis Ship <hl...@gmail.com>.
You are right this was sloppy on my part. Please add an issue and
I'll put together a fix (which will have the ugliness of a new
interface that starts with a deprecated method, but such is life).
On Mon, Mar 22, 2010 at 3:58 AM, Otho <ta...@googlemail.com> wrote:
> Hi all!
>
> I migrated a project to Spring 3. To make it work with Tapestry I had to
> upgrade to 5.2-Snapshot.
>
> Now I use RenderSupport.addScript(String scriptSnippet) and
> RenderSupport.addScriptLink(String) quite a lot.
> Both of them are deprecated and removed but the latter doesn't have a direct
> counterpart in the new JavascriptSupport service.
>
> The JavascriptSupport.importJavaScriptLibrary(Asset asset) makes dynamically
> building the script link tedious at least.
>
> I think this is quite a breaking change of the public API for a lot of apps
> which use RenderSupport.
>
> Is this only a transitional effect due to the beta nature of 5.2, or are
> these changes meant as final?
>
> If it is meant as final: Wouldn't it be better to deprecate the methods in
> RenderSupport but keep them in for compatibility with legacy apps and hint
> at the new JavascriptSupport for future projects and remove the deprecated
> API only at the next major version?
>
> Regards,
> Otho
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org