[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

[GitBox <gi...@apache.org>]

cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r335245040
 
 

 ##########
 File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java
 ##########
 @@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.drill.exec.store.excel;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonTypeName;
+import org.apache.drill.shaded.guava.com.google.common.base.Objects;
+import org.apache.drill.shaded.guava.com.google.common.collect.ImmutableList;
+import org.apache.drill.common.logical.FormatPluginConfig;
+import org.apache.drill.exec.store.excel.ExcelBatchReader.ExcelReaderConfig;
+
+import java.util.Arrays;
+import java.util.List;
+
+@JsonTypeName("excel")
+@JsonInclude(JsonInclude.Include.NON_DEFAULT)
+public class ExcelFormatConfig implements FormatPluginConfig {
+  //This is the theoretical maximum number of rows in an Excel spreadsheet
+  private final int MAX_ROWS = 1048576;
+
+  public List<String> extensions;
+
+  public int headerRow = 0;
+
+  public int lastRow = MAX_ROWS;
+
+  public int firstColumn = 0;
+
+  public int lastColumn = 0;
+
+  public boolean readAllFieldsAsVarChar = false;
+
+  public boolean evaluateFormulae = true;
+
+  public String sheetName = "";
 
 Review comment:
   I don't think either will pose a problem.  In the case of the empty string, the reader won't find a sheet with that name and throw an error.    If the sheetname is undefined, (`null`) the reader will default to the first sheet in the file. 
   
   https://github.com/apache/drill/blob/0a86d930a13e763e093fad52f3423d22cc4635b2/contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java#L227
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services