[GitHub] [tvm] tqchen commented on issue #9250: [Potential Bug] SSAVerifier needs some clarification and/or fix

[GitBox <gi...@apache.org>]

tqchen commented on issue #9250:
URL: https://github.com/apache/tvm/issues/9250#issuecomment-944911597


   Thank you for bringing this up!  Indeed we will need to make the condition stronger here such that under a weak ssa form, we would require the related expressions to do not call into function that have side effect or write into a state.
   
   Note that by default store have to appear in a Stmt so the case of memory write won't interleave with the two lets
   
   You are right that it is also think about whether or not such form was indeed necessary. The let expr is useful when it comes to express values that are CSEed.
   
   In the case of TIR, we do want to restrict where can effectful operations appear(hopefully in let statement, or eval) so the impact is minimized and most Expr can remain pure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org