You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/02/26 07:34:16 UTC

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain 

zhaorenhai@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15297


Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................

IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Download Python dependencies even skipping bootstrap toolchain.

Because when you set SKIP_TOOLCHAIN_BOOTSTRAP=true,
the python dependencies still need to be downloaded.
The toolchain building process will not download the python dependencies
autometically

Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
---
M buildall.sh
1 file changed, 10 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/15297/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5406/


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 12:32:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Feb 2020 17:11:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5533/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 02:48:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5406/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 07:43:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 07:45:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5344/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 08:19:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5579/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 02:39:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 6: Code-Review+2

Thank you for addressing that!


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 02:48:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 1:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5419/


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2020 11:23:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 1: Code-Review+2

LGTM.
Thanks for fixing this; it has bothered me for some time too.


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Sun, 22 Mar 2020 14:34:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 1:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5410/


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 20:18:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................

IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Download Python dependencies even skipping bootstrap toolchain.

Because when you set SKIP_TOOLCHAIN_BOOTSTRAP=true,
the python dependencies still need to be downloaded.
The toolchain building process will not download the python dependencies
autometically

Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
---
M bin/impala-config.sh
M buildall.sh
2 files changed, 10 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/15297/6
-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5410/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 16:16:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5429/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Feb 2020 12:15:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................

IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Download Python dependencies even skipping bootstrap toolchain.

Because when you set SKIP_TOOLCHAIN_BOOTSTRAP=true,
the python dependencies still need to be downloaded.
The toolchain building process will not download the python dependencies
autometically

Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Reviewed-on: http://gerrit.cloudera.org:8080/15297
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M buildall.sh
2 files changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 )

Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5419/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405
Gerrit-Change-Number: 15297
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2020 06:53:48 +0000
Gerrit-HasComments: No