[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

["Tong Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343109#comment-14343109 ] 

Tong Li commented on KAFKA-1988:
--------------------------------

[~guozhang] Yes, the o.a.k.c.c.u.Utils.abs used in few places.  in patch set for issue 1926, I will consolidate both Utils modules from clients and core into one. So that we do not have name conflict all over the place. The patch set for issue 1926 will be quite big. I would like to get this thing fixed for coming up release first, then we can address issue 1926. Thanks.

> org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.
> ----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-1988
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1988
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.2.0
>            Reporter: Tong Li
>            Assignee: Tong Li
>            Priority: Blocker
>             Fix For: 0.8.2.1
>
>         Attachments: KAFKA-1988.patch, KAFKA-1988.patch, KAFKA-1988.patch
>
>
> org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers. The method only returns intended value for positive numbers. All negative numbers except the Integer.Min_Value will be returned an unsigned integer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)