You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "jinhongyii (via GitHub)" <gi...@apache.org> on 2023/05/16 22:06:10 UTC

[GitHub] [tvm] jinhongyii opened a new pull request, #14864: [Unity]Lazy transform param now only work on non-dataflow block

jinhongyii opened a new pull request, #14864:
URL: https://github.com/apache/tvm/pull/14864

   As #14829 mentioned, `set_item` is an impure function, so LazyTransformParam Pass should be done after manually applyiyng ToNonDataflow pass. This PR corrects the behavior.
   
   cc: @slyubomirsky 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14864: [Unity]Lazy transform param now only work on non-dataflow block

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14864:
URL: https://github.com/apache/tvm/pull/14864#issuecomment-1550415419

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] slyubomirsky commented on pull request #14864: [Unity]Lazy transform param now only work on non-dataflow block

Posted by "slyubomirsky (via GitHub)" <gi...@apache.org>.
slyubomirsky commented on PR #14864:
URL: https://github.com/apache/tvm/pull/14864#issuecomment-1552263971

   Thank you for making the change :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jinhongyii commented on pull request #14864: [Unity]Lazy transform param now only work on non-dataflow block

Posted by "jinhongyii (via GitHub)" <gi...@apache.org>.
jinhongyii commented on PR #14864:
URL: https://github.com/apache/tvm/pull/14864#issuecomment-1551966963

   @tqchen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #14864: [Unity]Lazy transform param now only work on non-dataflow block

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #14864:
URL: https://github.com/apache/tvm/pull/14864


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org