[GitHub] DaanHoogland commented on a change in pull request #2672: CLOUDSTACK-10377: Fix Network restart for Nuage

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #2672: CLOUDSTACK-10377: Fix Network restart for Nuage
URL: https://github.com/apache/cloudstack/pull/2672#discussion_r193054806
 
 

 ##########
 File path: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##########
 @@ -723,6 +739,32 @@ public void deallocate(Network network, NicProfile nic, VirtualMachineProfile vm
             } else {
                 super.deallocate(network, nic, vm);
             }
+
+            if (virtualMachine.getType() == VirtualMachine.Type.DomainRouter) {
 
 Review comment:
   I am pretty sure @rafaelweingartner means the entire if block and not the enum check, @fmaximus 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services