[jira] Commented: (HDFS-505) Convert the file including 10 minutes run's tests into the test harness test suite

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735149#action_12735149 ] 

Konstantin Boudnik commented on HDFS-505:
-----------------------------------------

In order to clear possible confusion, I'd like to add a couple of comments here:

- it's big shame that JUnit doesn't support tests tagging contrary to a popular believe (see my comments for HADOOP-4901)

- because there's some opposition to bring in a 3rd party libraries into the project (again see HADOOP-4901) the tagging would have to be implemented through JUnit test suites instead.

- apparently, as Jacob has pointed out - we'd need to work around a potential problem of running the same tests twice (10 minutes ones and all of them in a single run). And there are some possible solutions for this, e.g. setting up test.exclude property to remove 10 minutes suite from a normal run; or to have a certain test class naming conventions, i.e. add a token 'Suite' into a class name and filter such classes out in a normal runs. Other approaches are, perhaps, possible to.


> Convert the file including 10 minutes run's tests into the test harness test suite
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-505
>                 URL: https://issues.apache.org/jira/browse/HDFS-505
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Konstantin Boudnik
>
> This issue is created to track the conversion of external testlist for 10 minutes tests into JUnit test suite.
> It would be consistent through the bigger Hadoop project to have 10 minutes tests to be collected in a JUnit's test suite instead of an external file (as of now). 
> The reason is simple: with the file we'd have two points of maintenance: tests source code and one an auxiliary text files. Besides, a general approach is to use JUnit's suites for tagging purposes, thus having a suite here would be more uniform.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.