You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/07/01 15:04:16 UTC

[GitHub] storm pull request #1534: STORM-1941 Nimbus discovery can fail when zookeepe...

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/1534

    STORM-1941 Nimbus discovery can fail when zookeeper reconnect happens. (1.x)

    * delete ephemeral node first when reconnected handler is called
    
    This also deletes node if session is alive but reconnected.
    If we really need to avoid deleting node, we could check ephemeral owner before deleting. Zookeeper reconnect is not happening so often, so I guess it's fine to not applying. If you think we should, please let me know.
    
    Btw, blobstore also uses ephemeral nodes so I'm curious they should be recreated too.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-1941-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1534.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1534
    
----
commit 44ffed3e846597100e8f1c9914811ac1d9907e17
Author: Jungtaek Lim <ka...@gmail.com>
Date:   2016-07-01T14:54:15Z

    STORM-1941 Nimbus discovery can fail when zookeeper reconnect happens.
    
    * delete ephemeral node first when reconnected handler is called

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1534: STORM-1941 Nimbus discovery can fail when zookeepe...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1534


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---