You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/02/03 00:07:47 UTC
[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #227: [YUNIKORN-536] Add resource requests and limits for the admission-controller
yangwwei opened a new pull request #227:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] kingamarton commented on a change in pull request #227: [YUNIKORN-536] Add resource requests and limits for the admission-controller
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #227:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/227#discussion_r569361879
##########
File path: deployments/admission-controllers/scheduler/templates/server.yaml.template
##########
@@ -37,6 +37,13 @@ spec:
ports:
- containerPort: 9089
name: webhook-api
+ resources:
+ limits:
+ cpu: "100m"
+ memory: 500Mi
+ requests:
+ cpu: "500m"
+ memory: 500Mi
Review comment:
Can you please explain how you decided about this values?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #227: [YUNIKORN-536] Add resource requests and limits for the admission-controller
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #227:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/227#issuecomment-772107264
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=h1) Report
> Merging [#227](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=desc) (c4f7ad1) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.23%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 59.75% 59.51% -0.24%
==========================================
Files 35 35
Lines 3133 3127 -6
==========================================
- Hits 1872 1861 -11
- Misses 1180 1184 +4
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <0.00%> (-0.33%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=footer). Last update [d8f8921...c4f7ad1](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #227: [YUNIKORN-536] Add resource requests and limits for the admission-controller
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #227:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/227#discussion_r569614170
##########
File path: deployments/admission-controllers/scheduler/templates/server.yaml.template
##########
@@ -37,6 +37,13 @@ spec:
ports:
- containerPort: 9089
name: webhook-api
+ resources:
+ limits:
+ cpu: "100m"
+ memory: 500Mi
+ requests:
+ cpu: "500m"
+ memory: 500Mi
Review comment:
I've done some observations on a live cluster, leveraging kubectl top command, I was able to see the resource utilization of the admission controller pod, it is not using a lot of resources. I tried to create hundreds of pods in a loop to add some loads, it only uses 1~2m CPU, and less than 10m memory, pretty lightweight. So I think this number is sufficient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #227: [YUNIKORN-536] Add resource requests and limits for the admission-controller
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #227:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/227#issuecomment-772107264
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=h1) Report
> Merging [#227](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=desc) (ee69b59) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.22%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 59.75% 59.52% -0.23%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
- Hits 1872 1862 -10
- Misses 1180 1184 +4
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=footer). Last update [d8f8921...ee69b59](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #227: [YUNIKORN-536] Add resource requests and limits for the admission-controller
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #227:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/227#issuecomment-772107264
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=h1) Report
> Merging [#227](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=desc) (ee69b59) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.22%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 59.75% 59.52% -0.23%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
- Hits 1872 1862 -10
- Misses 1180 1184 +4
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=footer). Last update [d8f8921...c4f7ad1](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #227: [YUNIKORN-536] Add resource requests and limits for the admission-controller
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #227:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/227#issuecomment-772107264
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=h1) Report
> Merging [#227](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=desc) (ee69b59) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.22%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 59.75% 59.52% -0.23%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
- Hits 1872 1862 -10
- Misses 1180 1184 +4
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=footer). Last update [d8f8921...ee69b59](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/227?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #227: [YUNIKORN-536] Add resource requests and limits for the admission-controller
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #227:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org