You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/10/23 16:05:15 UTC
[PR] [improve][test] Fix test retries for tests that don't call internalSetup [pulsar]
lhotari opened a new pull request, #21422:
URL: https://github.com/apache/pulsar/pull/21422
### Motivation
Tests that support retries with TestRetrySupport class should call `incrementSetupNumber` method as part of initialization so that while retrying the test, it can be detected that the initialization methods should be called before retrying. This support is needed when BeforeClass/AfterClass methods are used for initializing the test state.
Some tests which extend `MockedPulsarServiceBaseTest` call the `init` method instead of using `internalSetup` where the `incrementSetupNumber` method is called. By moving the call to the `init` method, these tests will also properly handle test retries where initialization is done in a method annotated with `@BeforeClass`.
### Modifications
Move the `incrementSetupNumber` call in `MockedPulsarServiceBaseTest` from the `internalSetup` method to `init` method.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][test] Fix test retries for tests that don't call internalSetup [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #21422:
URL: https://github.com/apache/pulsar/pull/21422#issuecomment-1776170727
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][test] Fix test retries for tests that don't call internalSetup [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21422:
URL: https://github.com/apache/pulsar/pull/21422#issuecomment-1776382499
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21422?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21422](https://app.codecov.io/gh/apache/pulsar/pull/21422?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (605b2cd) into [master](https://app.codecov.io/gh/apache/pulsar/commit/a0f8b0d16840118388f258a6ef7ac6e76d564a15?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a0f8b0d) will **increase** coverage by `38.74%`.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/21422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21422 +/- ##
=============================================
+ Coverage 34.55% 73.30% +38.74%
- Complexity 12083 32573 +20490
=============================================
Files 1711 1888 +177
Lines 130708 140307 +9599
Branches 14245 15420 +1175
=============================================
+ Hits 45172 102852 +57680
+ Misses 79503 29369 -50134
- Partials 6033 8086 +2053
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21422/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21422/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.17% <ø> (?)` | |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21422/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.85% <ø> (+0.06%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21422/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.57% <ø> (+40.70%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1472 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21422/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][test] Fix test retries for tests that don't call internalSetup [pulsar]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #21422:
URL: https://github.com/apache/pulsar/pull/21422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org