You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/04/01 19:59:34 UTC
[GitHub] [trafficcontrol] srijeet0406 opened a new pull request #5701: todb-tests GitHub action does not run the Traffic Ops DB tests
srijeet0406 opened a new pull request #5701:
URL: https://github.com/apache/trafficcontrol/pull/5701
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [x] This PR fixes #5449 <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- Traffic Ops
- CI tests
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
Make sure the `Traffic Ops Database Tests` GHA passes on a new PR/ push, and that it runs the two new steps, namely, `Build And Copy Traffic Ops RPM` and `Run Traffic Ops Database Docker Tests`.
## If this is a bug fix, what versions of Traffic Control are affected?
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
- master
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] This PR does not include tests
- [x] This PR does not include documentation
- [x] This PR includes an update to CHANGELOG.md
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] srijeet0406 commented on a change in pull request #5701: todb-tests GitHub action does not run the Traffic Ops DB tests
Posted by GitBox <gi...@apache.org>.
srijeet0406 commented on a change in pull request #5701:
URL: https://github.com/apache/trafficcontrol/pull/5701#discussion_r606022468
##########
File path: traffic_ops/app/db/admin.go
##########
@@ -176,8 +176,9 @@ func createDB() {
stderr := bytes.Buffer{}
dbExistsCmd.Stderr = &stderr
out, err := dbExistsCmd.Output()
+ // An error is returned if the database could not be found, which is to be expected. Don't exit on this error.
Review comment:
So this command is checking to see if the database is present or not. However, the command returns an error if that particular database is not present. For example, in my local docker container, it returns the following error if I keep the `die` on this step:
`trafficops-db-admin_1 | unable to check if DB already exists: exit status 2, stderr: psql: error: FATAL: database "traffic_ops" does not exist`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #5701: todb-tests GitHub action does not run the Traffic Ops DB tests
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #5701:
URL: https://github.com/apache/trafficcontrol/pull/5701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] srijeet0406 commented on a change in pull request #5701: todb-tests GitHub action does not run the Traffic Ops DB tests
Posted by GitBox <gi...@apache.org>.
srijeet0406 commented on a change in pull request #5701:
URL: https://github.com/apache/trafficcontrol/pull/5701#discussion_r606061822
##########
File path: traffic_ops/app/db/admin.go
##########
@@ -176,8 +176,9 @@ func createDB() {
stderr := bytes.Buffer{}
dbExistsCmd.Stderr = &stderr
out, err := dbExistsCmd.Output()
+ // An error is returned if the database could not be found, which is to be expected. Don't exit on this error.
Review comment:
yeah I have been debugging it today and seems like it was due to the database not being present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5701: todb-tests GitHub action does not run the Traffic Ops DB tests
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5701:
URL: https://github.com/apache/trafficcontrol/pull/5701#discussion_r605977460
##########
File path: traffic_ops_db/test/docker/docker-compose.yml
##########
@@ -43,7 +43,7 @@ services:
dockerfile: Dockerfile-db-admin
args:
POSTGRES_VERSION: ${POSTGRES_VERSION:-13.2}
- TRAFFIC_OPS_RPM: traffic_ops.rpm
+ TRAFFIC_OPS_RPM: traffic_ops-*.rpm
Review comment:
I think you could avoid this change by just being explicit about the destination filename. I'm not really sure that's a big deal, but for CI systems running this test that for whatever reason have cluttered directories it could cause them to start installing a bunch of different TO versions at once instead of the one they want. Again, idk if anyone's doing that - and it seems like not a great thing to do - but I just thought I'd make the note.
##########
File path: traffic_ops/app/db/admin.go
##########
@@ -176,8 +176,9 @@ func createDB() {
stderr := bytes.Buffer{}
dbExistsCmd.Stderr = &stderr
out, err := dbExistsCmd.Output()
+ // An error is returned if the database could not be found, which is to be expected. Don't exit on this error.
Review comment:
Why is that to be expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5701: todb-tests GitHub action does not run the Traffic Ops DB tests
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5701:
URL: https://github.com/apache/trafficcontrol/pull/5701#discussion_r606070792
##########
File path: traffic_ops/app/db/admin.go
##########
@@ -176,8 +176,9 @@ func createDB() {
stderr := bytes.Buffer{}
dbExistsCmd.Stderr = &stderr
out, err := dbExistsCmd.Output()
+ // An error is returned if the database could not be found, which is to be expected. Don't exit on this error.
Review comment:
No I mean the code should figure out which happened and only fail if there was a real failure, and not just because the DB already existed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5701: todb-tests GitHub action does not run the Traffic Ops DB tests
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5701:
URL: https://github.com/apache/trafficcontrol/pull/5701#discussion_r606048921
##########
File path: traffic_ops/app/db/admin.go
##########
@@ -176,8 +176,9 @@ func createDB() {
stderr := bytes.Buffer{}
dbExistsCmd.Stderr = &stderr
out, err := dbExistsCmd.Output()
+ // An error is returned if the database could not be found, which is to be expected. Don't exit on this error.
Review comment:
ohhh, gotcha. You don't need to fix it in this PR, but we should really find out whether it was a real failure or just the database not existing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org