[GitHub] [geode] demery-pivotal commented on a diff in pull request #7608: Bugfix/GEODE-10228 DurableClientTestCase.testDurableHAFailover is failing

[GitBox <gi...@apache.org>]

demery-pivotal commented on code in PR #7608:
URL: https://github.com/apache/geode/pull/7608#discussion_r857993461


##########
geode-core/src/distributedTest/java/org/apache/geode/cache/client/ClientServerRegisterInterestsDUnitTest.java:
##########
@@ -224,27 +205,27 @@ public void testClientRegisterInterests() {
       Region<String, String> example = clientCache.getRegion(SEPARATOR + "Example");
 
       assertNotNull("'Example' Region in Client Cache was not found!", example);
-      assertEquals(1, example.size());
+      assertThat(example.size()).isEqualTo(1);
       assertTrue(example.containsKey("1"));
-      assertEquals("ONE", example.get("1"));
+      assertThat(example.get("1")).isEqualTo("ONE");

Review Comment:
   I much prefer the first form, describing the map, the expectation, the missing entries, and the unexpected entries. All of that information is very useful for diagnosing failures.
   
   Adding `.as("region in client cache")` would make it even more helpful.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org