[jira] Updated: (DERBY-3755) ij's help text lacks the optional [HOLD | NOHOLD] syntax for GET CURSOR

["Dag H. Wanvik (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-3755:
---------------------------------

    Attachment: derby-3755.stat
                derby-3755.diff

Thanks for looking at this Kim. You are right, the WITH keyword is
required.  Uploading a patch, derby-3755, which corrects the syntax
for all the locales thus:

GET [SCROLL INSENSITIVE] [WITH { HOLD | NOHOLD }] CURSOR ....

It should be safe to edit the locale files even for a non-native
speaker since the addition is in syntax part only.

I manually checked English, German, Italian, simplified and
traditional Chinese output (e.g. using java -Dderby.ui.locale=zh_CN
-Dderby.ui.codeset=utf8 org.apache.derby.tools.ij) to verify that the
output still looks ok.

Btw, it seems odd that the codeset used for output is still ISO8859-1
even if locale is specified say as Chinese. If I omit the
derby.ui.codeset setting, I only see question marks for the Chinese
characters.  "utf8" might be a more sensible default for non-western
locales.



> ij's help text lacks the optional [HOLD | NOHOLD] syntax for GET CURSOR
> -----------------------------------------------------------------------
>
>                 Key: DERBY-3755
>                 URL: https://issues.apache.org/jira/browse/DERBY-3755
>             Project: Derby
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Dag H. Wanvik
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3755.diff, derby-3755.stat
>
>
> ij's help command shows the syntax of GET CURSOR as:
> GET [SCROLL INSENSITIVE] CURSOR name AS 'SQL-J query';
>                                -- gets a cursor (JDBC result set) on the query
>                                -- SCROLL cursors are only available 
>                                -- in JDBC 2.0 and higher. 
>                                -- (Cursor scroll type is ignored in JDBC 1.X.) 
> One can actually also specify holdability, so the syntax show read:
> GET [SCROLL INSENSITIVE] [HOLD | NOHOLD] CURSOR name AS 'SQL-J query';
> and the comment should also state that HOLD is the default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.