[GitHub] [incubator-ratis] szetszwo commented on a change in pull request #276: RATIS-1155. Add a builder for DataStreamReplyByteBuffer.

[GitBox <gi...@apache.org>]

szetszwo commented on a change in pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276#discussion_r523363738



##########
File path: ratis-client/src/main/java/org/apache/ratis/client/impl/OrderedStreamAsync.java
##########
@@ -43,8 +43,8 @@
     private final long seqNum;
     private final CompletableFuture<DataStreamReply> replyFuture = new CompletableFuture<>();
 
-    DataStreamWindowRequest(long streamId, long offset, ByteBuffer data, long seqNum, Type type){
-      super(streamId, offset, data, type);
+    DataStreamWindowRequest(Type type, long streamId, long offset, ByteBuffer data, long seqNum) {

Review comment:
       `Type type, long streamId, long offset` should be put together in the same order.  It will be consistent throughout the code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org