You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2021/06/22 00:51:38 UTC
[Impala-ASF-CR] IMPALA-10760: Added accessor methods to Function classes
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17614
Change subject: IMPALA-10760: Added accessor methods to Function classes
......................................................................
IMPALA-10760: Added accessor methods to Function classes
Small modification to allow the rest of the "symbol" functions
to be visible outside the class.
Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582
---
M fe/src/main/java/org/apache/impala/catalog/AggregateFunction.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/17614/1
--
To view, visit http://gerrit.cloudera.org:8080/17614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582
Gerrit-Change-Number: 17614
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-10760: Added accessor methods to Function classes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17614 )
Change subject: IMPALA-10760: Added accessor methods to Function classes
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8963/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582
Gerrit-Change-Number: 17614
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 02:01:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10760: Added accessor methods to Function classes
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17614 )
Change subject: IMPALA-10760: Added accessor methods to Function classes
......................................................................
Patch Set 5: Verified+1 Code-Review+2
Carry previous +2 and Verified +1
--
To view, visit http://gerrit.cloudera.org:8080/17614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582
Gerrit-Change-Number: 17614
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 17:43:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10760: Added accessor methods to Function classes
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17614 )
Change subject: IMPALA-10760: Added accessor methods to Function classes
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
couple of nits.
http://gerrit.cloudera.org:8080/#/c/17614/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17614/2//COMMIT_MSG@9
PS2, Line 9: functions
nit: these are symbol strings rather than functions ?
http://gerrit.cloudera.org:8080/#/c/17614/2//COMMIT_MSG@10
PS2, Line 10: class
nit: might want to say Function classes (or Aggregate/Scalar function classes).
--
To view, visit http://gerrit.cloudera.org:8080/17614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582
Gerrit-Change-Number: 17614
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 02:47:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10760: Added accessor methods to Function classes
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17614 )
Change subject: IMPALA-10760: Added accessor methods to Function classes
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17614/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17614/2//COMMIT_MSG@9
PS2, Line 9: functions
> nit: these are symbol strings rather than functions ?
Done
http://gerrit.cloudera.org:8080/#/c/17614/2//COMMIT_MSG@10
PS2, Line 10: class
> nit: might want to say Function classes (or Aggregate/Scalar function class
Done
--
To view, visit http://gerrit.cloudera.org:8080/17614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582
Gerrit-Change-Number: 17614
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 03:43:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10760: Added accessor methods to Function classes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17614 )
Change subject: IMPALA-10760: Added accessor methods to Function classes
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8962/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582
Gerrit-Change-Number: 17614
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 01:12:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10760: Added accessor methods to Function classes
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17614 )
Change subject: IMPALA-10760: Added accessor methods to Function classes
......................................................................
IMPALA-10760: Added accessor methods to Function classes
Small modification to allow the rest of the "symbol" functions
to be visible outside the class.
These are necessary for an external frontend to access these
symbols.
Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582
---
M fe/src/main/java/org/apache/impala/catalog/AggregateFunction.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/17614/2
--
To view, visit http://gerrit.cloudera.org:8080/17614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582
Gerrit-Change-Number: 17614
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10760: Added accessor methods to Function classes
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17614 )
Change subject: IMPALA-10760: Added accessor methods to Function classes
......................................................................
IMPALA-10760: Added accessor methods to Function classes
Small modification to allow the rest of the "symbol" strings
to be visible outside the Function classes.
These are necessary for an external frontend to access these
symbols.
Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582
Reviewed-on: http://gerrit.cloudera.org:8080/17614
Reviewed-by: Aman Sinha <am...@cloudera.com>
Tested-by: Aman Sinha <am...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/AggregateFunction.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Aman Sinha: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582
Gerrit-Change-Number: 17614
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>