You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/07/31 14:33:29 UTC
Review Request 24153: Configs API + Blueprints: Handle deprecation of global
config_type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-6695
https://issues.apache.org/jira/browse/AMBARI-6695
Repository: ambari
Description
-------
How to handle support for blueprints + configs API where global configs are
set, since global config_type is being eliminated.
* warn that global is deprecated
* map global to whatever-the-new-config-type automatically
jspeidel this affects blueprints and the configs API
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 906cba4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 5f67a30
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
Diff: https://reviews.apache.org/r/24153/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/#review49251
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On July 31, 2014, 12:09 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24153/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 12:09 p.m.)
>
>
> Review request for Ambari, John Speidel, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-6695
> https://issues.apache.org/jira/browse/AMBARI-6695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> How to handle support for blueprints + configs API where global configs are
> set, since global config_type is being eliminated.
>
> * warn that global is deprecated
> * map global to whatever-the-new-config-type automatically
>
> jspeidel this affects blueprints and the configs API
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 906cba4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 5f67a30
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
>
> Diff: https://reviews.apache.org/r/24153/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/
-----------------------------------------------------------
(Updated July 31, 2014, 11:10 p.m.)
Review request for Ambari, John Speidel, Mahadev Konar, Nate Cole, and Vitalyi Brodetskyi.
Bugs: AMBARI-6695
https://issues.apache.org/jira/browse/AMBARI-6695
Repository: ambari
Description
-------
How to handle support for blueprints + configs API where global configs are
set, since global config_type is being eliminated.
* warn that global is deprecated
* map global to whatever-the-new-config-type automatically
jspeidel this affects blueprints and the configs API
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8a8b792
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java f071e64
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
Diff: https://reviews.apache.org/r/24153/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/#review49299
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On July 31, 2014, 11:03 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24153/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 11:03 p.m.)
>
>
> Review request for Ambari, John Speidel, Mahadev Konar, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-6695
> https://issues.apache.org/jira/browse/AMBARI-6695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> How to handle support for blueprints + configs API where global configs are
> set, since global config_type is being eliminated.
>
> * warn that global is deprecated
> * map global to whatever-the-new-config-type automatically
>
> jspeidel this affects blueprints and the configs API
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c65561e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
>
> Diff: https://reviews.apache.org/r/24153/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/#review49300
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On July 31, 2014, 11:03 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24153/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 11:03 p.m.)
>
>
> Review request for Ambari, John Speidel, Mahadev Konar, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-6695
> https://issues.apache.org/jira/browse/AMBARI-6695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> How to handle support for blueprints + configs API where global configs are
> set, since global config_type is being eliminated.
>
> * warn that global is deprecated
> * map global to whatever-the-new-config-type automatically
>
> jspeidel this affects blueprints and the configs API
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c65561e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
>
> Diff: https://reviews.apache.org/r/24153/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/
-----------------------------------------------------------
(Updated July 31, 2014, 11:03 p.m.)
Review request for Ambari, John Speidel, Mahadev Konar, Nate Cole, and Vitalyi Brodetskyi.
Bugs: AMBARI-6695
https://issues.apache.org/jira/browse/AMBARI-6695
Repository: ambari
Description
-------
How to handle support for blueprints + configs API where global configs are
set, since global config_type is being eliminated.
* warn that global is deprecated
* map global to whatever-the-new-config-type automatically
jspeidel this affects blueprints and the configs API
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c65561e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
Diff: https://reviews.apache.org/r/24153/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/
-----------------------------------------------------------
(Updated July 31, 2014, 10:10 p.m.)
Review request for Ambari, John Speidel, Nate Cole, and Vitalyi Brodetskyi.
Changes
-------
Done
Bugs: AMBARI-6695
https://issues.apache.org/jira/browse/AMBARI-6695
Repository: ambari
Description
-------
How to handle support for blueprints + configs API where global configs are
set, since global config_type is being eliminated.
* warn that global is deprecated
* map global to whatever-the-new-config-type automatically
jspeidel this affects blueprints and the configs API
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c65561e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
Diff: https://reviews.apache.org/r/24153/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On July 31, 2014, 4:40 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, lines 643-668
> > <https://reviews.apache.org/r/24153/diff/1/?file=646844#file646844line643>
> >
> > Seems like adding configurations named 'global' shoudl still be allowed, even if we don't use it. We should ADD a -env set if a name was found, but not remove the key/value pair from what was passed in. That makes the behavior confusing: "I passed in a name and value that wasn't saved"
When we pass parameters which were not in global in past, they are still posted to global. Not removed. Only the paramaters which are found in some -env are moved there.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/#review49241
-----------------------------------------------------------
On July 31, 2014, 4:09 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24153/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 4:09 p.m.)
>
>
> Review request for Ambari, John Speidel, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-6695
> https://issues.apache.org/jira/browse/AMBARI-6695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> How to handle support for blueprints + configs API where global configs are
> set, since global config_type is being eliminated.
>
> * warn that global is deprecated
> * map global to whatever-the-new-config-type automatically
>
> jspeidel this affects blueprints and the configs API
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 906cba4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 5f67a30
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
>
> Diff: https://reviews.apache.org/r/24153/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On July 31, 2014, 4:40 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, lines 643-668
> > <https://reviews.apache.org/r/24153/diff/1/?file=646844#file646844line643>
> >
> > Seems like adding configurations named 'global' shoudl still be allowed, even if we don't use it. We should ADD a -env set if a name was found, but not remove the key/value pair from what was passed in. That makes the behavior confusing: "I passed in a name and value that wasn't saved"
>
> Andrew Onischuk wrote:
> When we pass parameters which were not in global in past, they are still posted to global. Not removed. Only the paramaters which are found in some -env are moved there.
Talked about this with Mahadev, he said we should just do moving the configs, if we know where to move.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/#review49241
-----------------------------------------------------------
On July 31, 2014, 10:10 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24153/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 10:10 p.m.)
>
>
> Review request for Ambari, John Speidel, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-6695
> https://issues.apache.org/jira/browse/AMBARI-6695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> How to handle support for blueprints + configs API where global configs are
> set, since global config_type is being eliminated.
>
> * warn that global is deprecated
> * map global to whatever-the-new-config-type automatically
>
> jspeidel this affects blueprints and the configs API
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c65561e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
>
> Diff: https://reviews.apache.org/r/24153/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/#review49241
-----------------------------------------------------------
With regard to blueprint (John can probably answer) - do we need to worry about loading a blueprint out of the database?
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/24153/#comment86130>
Seems like adding configurations named 'global' shoudl still be allowed, even if we don't use it. We should ADD a -env set if a name was found, but not remove the key/value pair from what was passed in. That makes the behavior confusing: "I passed in a name and value that wasn't saved"
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/24153/#comment86127>
add spaces around the :
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
<https://reviews.apache.org/r/24153/#comment86126>
Depracted shold be Deprecated
- Nate Cole
On July 31, 2014, 12:09 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24153/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 12:09 p.m.)
>
>
> Review request for Ambari, John Speidel, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-6695
> https://issues.apache.org/jira/browse/AMBARI-6695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> How to handle support for blueprints + configs API where global configs are
> set, since global config_type is being eliminated.
>
> * warn that global is deprecated
> * map global to whatever-the-new-config-type automatically
>
> jspeidel this affects blueprints and the configs API
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 906cba4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 5f67a30
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
>
> Diff: https://reviews.apache.org/r/24153/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/#review49280
-----------------------------------------------------------
Note that if the user provides any globals in blueprint or othereise via api's it should bould down to respective config changes - no globals getting created.
- Mahadev Konar
On July 31, 2014, 4:09 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24153/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 4:09 p.m.)
>
>
> Review request for Ambari, John Speidel, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-6695
> https://issues.apache.org/jira/browse/AMBARI-6695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> How to handle support for blueprints + configs API where global configs are
> set, since global config_type is being eliminated.
>
> * warn that global is deprecated
> * map global to whatever-the-new-config-type automatically
>
> jspeidel this affects blueprints and the configs API
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 906cba4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 5f67a30
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
>
> Diff: https://reviews.apache.org/r/24153/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/#review49250
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
<https://reviews.apache.org/r/24153/#comment86196>
not thrown
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
<https://reviews.apache.org/r/24153/#comment86191>
not thrown
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
<https://reviews.apache.org/r/24153/#comment86188>
Question about need to do conversion of globals here.
I see that this is also handled in AmbariManagementControllerImpl.createConfiguration(). I didn't trace through all of the configuration creation code but assume that the AMCI.createConfiguration() is called when we set configurations on the cluster. To me, it makes more sense to do this global conversion at a lower level than the BP processing code as you are doing in AMCI. Why do we also need to do this here in the BP processing code. Ideally, it would be all done where the configuration is actually being processed at a lower level.
In addition to configurations being created in BP processing, some clients are still using the underlying REST API calls to provision clusters until they switch over to blueprints. If the global migration logic wasn't handled at a lower common level, these API calls would also need to do the conversion. Also, the BP global conversion isn't being called for host group scoped configurations, only cluster scoped.
So to summarize, why do we need to handle global conversion in the BP processing code as opposed to doing it at a lower level where the configuration are processed.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
<https://reviews.apache.org/r/24153/#comment86152>
The setting of these 3 properties associated with AMBARI-4921 should be removed as user_group and smokeuser have been added to the stack and nagios_contact is a required input for the user.
- John Speidel
On July 31, 2014, 4:09 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24153/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 4:09 p.m.)
>
>
> Review request for Ambari, John Speidel, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-6695
> https://issues.apache.org/jira/browse/AMBARI-6695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> How to handle support for blueprints + configs API where global configs are
> set, since global config_type is being eliminated.
>
> * warn that global is deprecated
> * map global to whatever-the-new-config-type automatically
>
> jspeidel this affects blueprints and the configs API
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 906cba4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 5f67a30
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
>
> Diff: https://reviews.apache.org/r/24153/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/
-----------------------------------------------------------
(Updated July 31, 2014, 4:09 p.m.)
Review request for Ambari, John Speidel, Nate Cole, and Vitalyi Brodetskyi.
Bugs: AMBARI-6695
https://issues.apache.org/jira/browse/AMBARI-6695
Repository: ambari
Description
-------
How to handle support for blueprints + configs API where global configs are
set, since global config_type is being eliminated.
* warn that global is deprecated
* map global to whatever-the-new-config-type automatically
jspeidel this affects blueprints and the configs API
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 906cba4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 5f67a30
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
Diff: https://reviews.apache.org/r/24153/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of
global config_type
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/
-----------------------------------------------------------
(Updated July 31, 2014, 4:06 p.m.)
Review request for Ambari, Nate Cole and Vitalyi Brodetskyi.
Bugs: AMBARI-6695
https://issues.apache.org/jira/browse/AMBARI-6695
Repository: ambari
Description
-------
How to handle support for blueprints + configs API where global configs are
set, since global config_type is being eliminated.
* warn that global is deprecated
* map global to whatever-the-new-config-type automatically
jspeidel this affects blueprints and the configs API
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 906cba4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 5f67a30
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc
Diff: https://reviews.apache.org/r/24153/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk