You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/13 21:32:21 UTC

[GitHub] [beam] ihji commented on a change in pull request #11409: [BEAM-2939] Update unbounded source as SDF wrapper to resume successfully.

ihji commented on a change in pull request #11409: [BEAM-2939] Update unbounded source as SDF wrapper to resume successfully.
URL: https://github.com/apache/beam/pull/11409#discussion_r407734012
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
 ##########
 @@ -743,8 +727,6 @@ public boolean tryClaim(UnboundedSourceValue<OutputT>[] position) {
               currentReader.close();
             } catch (IOException closeException) {
               e.addSuppressed(closeException);
-            } finally {
 
 Review comment:
   Intended?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services