You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/12/23 07:10:47 UTC

[GitHub] [zookeeper] lanicc opened a new pull request #1563: ZOOKEEPER-4034: Replace lambda with method reference

lanicc opened a new pull request #1563:
URL: https://github.com/apache/zookeeper/pull/1563


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] lanicc commented on pull request #1563: ZOOKEEPER-4034: Replace lambda with method reference

Posted by GitBox <gi...@apache.org>.
lanicc commented on pull request #1563:
URL: https://github.com/apache/zookeeper/pull/1563#issuecomment-751635024


   > Thank you for your contribution.
   > 
   > In my opinion this kind of patches is not worth to be committed.
   > 'Don't fix things that are not broken' is a good motto.
   > 
   > This change does not add much value, but it my affect the execution at runtime.
   > It may look like nitpicking but it is a broader thought.
   > We should change code only if there is a good reason do to it.
   > Even in this case the behaviour may be different for some JVM, so why risk to break things?
   > 
   > @lanicc I encourage you to submit other patches, it is very appreciated here, but it is better to pick up some known issue and try to fix it or if we want to reduce our technical debt probably it is better to pick up a topic (using method references?) and address the problem more globally
   
   Thank you for your reply, I accept it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] lanicc commented on pull request #1563: ZOOKEEPER-4034: Replace lambda with method reference

Posted by GitBox <gi...@apache.org>.
lanicc commented on pull request #1563:
URL: https://github.com/apache/zookeeper/pull/1563#issuecomment-751535423


   > +0. It's just another alternative way. It's hard to say it's an optimization？
   
   Yes. It's not really an optimization, just a simplification of the code


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] lanicc closed pull request #1563: ZOOKEEPER-4034: Replace lambda with method reference

Posted by GitBox <gi...@apache.org>.
lanicc closed pull request #1563:
URL: https://github.com/apache/zookeeper/pull/1563


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org