[GitHub] [camel] ttyy1112 commented on pull request #5890: FIX: can not use endChoice() in nest choice DSL

[GitBox <gi...@apache.org>]

ttyy1112 commented on pull request #5890:
URL: https://github.com/apache/camel/pull/5890#issuecomment-889760939


   > This causes problems, you should have run the unit tests of camel-core first.
   > 
   > If you enable dump routes, you can better see the model
   > 
   > ```
   >  context.setDumpRoutes(true);
   > ```
   
   Well, I just saw the test case about EIP choice, It seems like that endChoice() is pair of choice(), but in some situation it does not, such as when you add another EIP DSL in you when clause, you should also add the endChoice() after when clause. So in when or otherwise clause, I have to decide in advance use endChoice() or not . 
   
   Sometimes, I want to generate the Java-DSL dynamically and I don't know how many nest choices  it will be, and also have no idea whether there is another EIP DSL in the when clause or not. So In this case, I hope the choice clause  below would always work.
   
   .choice()
     .when().log().endChoice()
     .when().log().endChoice()
     .otherwise().log().endChoice()
   .end()
     
   Though a little redundancy, I think it will simple in use.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org