You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ozone.apache.org by ad...@apache.org on 2023/04/19 09:33:12 UTC
[ozone] branch master updated: HDDS-7309. Enable by default GRPC between S3G and OM (#3820)
This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new e61f348362 HDDS-7309. Enable by default GRPC between S3G and OM (#3820)
e61f348362 is described below
commit e61f348362acc7a097ae5d8fcdb66cba13443445
Author: Christos Bisias <ch...@gmail.com>
AuthorDate: Wed Apr 19 12:33:03 2023 +0300
HDDS-7309. Enable by default GRPC between S3G and OM (#3820)
---
hadoop-hdds/common/src/main/resources/ozone-default.xml | 8 ++++++++
.../java/org/apache/hadoop/ozone/om/OMConfigKeys.java | 2 +-
hadoop-ozone/dist/src/main/compose/ozone/docker-config | 1 -
.../dist/src/main/compose/ozonesecure-ha/docker-config | 1 -
.../dist/src/main/compose/ozonesecure/docker-config | 1 -
.../apache/hadoop/ozone/TestOzoneConfigurationFields.java | 1 -
.../integration-test/src/test/resources/ozone-site.xml | 10 ++++++++++
...g.apache.hadoop.ozone.om.protocolPB.OmTransportFactory | 15 +++++++++++++++
8 files changed, 34 insertions(+), 5 deletions(-)
diff --git a/hadoop-hdds/common/src/main/resources/ozone-default.xml b/hadoop-hdds/common/src/main/resources/ozone-default.xml
index f8f908b909..1879ac4f6c 100644
--- a/hadoop-hdds/common/src/main/resources/ozone-default.xml
+++ b/hadoop-hdds/common/src/main/resources/ozone-default.xml
@@ -2589,6 +2589,14 @@
for Ozone Manager Admin protocol.
</description>
</property>
+ <property>
+ <name>ozone.om.transport.class</name>
+ <value>org.apache.hadoop.ozone.om.protocolPB.GrpcOmTransportFactory</value>
+ <tag>OM, MANAGEMENT</tag>
+ <description>
+ Enable Ozone Manager S3G Grpc channel.
+ </description>
+ </property>
<property>
<name>ozone.recon.http.enabled</name>
<value>true</value>
diff --git a/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java b/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
index 34e17519e0..83d31fd227 100644
--- a/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
+++ b/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
@@ -367,7 +367,7 @@ public final class OMConfigKeys {
public static final String OZONE_OM_S3_GPRC_SERVER_ENABLED =
"ozone.om.s3.grpc.server_enabled";
public static final boolean OZONE_OM_S3_GRPC_SERVER_ENABLED_DEFAULT =
- false;
+ true;
/**
* Configuration properties for OMAdminProtcol service.
*/
diff --git a/hadoop-ozone/dist/src/main/compose/ozone/docker-config b/hadoop-ozone/dist/src/main/compose/ozone/docker-config
index 291df6fde9..adedb04ca4 100644
--- a/hadoop-ozone/dist/src/main/compose/ozone/docker-config
+++ b/hadoop-ozone/dist/src/main/compose/ozone/docker-config
@@ -42,7 +42,6 @@ OZONE-SITE.XML_ozone.recon.om.snapshot.task.interval.delay=1m
OZONE-SITE.XML_ozone.datanode.pipeline.limit=1
OZONE-SITE.XML_hdds.scmclient.max.retry.timeout=30s
OZONE-SITE.XML_hdds.container.report.interval=60s
-OZONE-SITE.XML_ozone.om.s3.grpc.server_enabled=true
OZONE-SITE.XML_ozone.scm.stale.node.interval=30s
OZONE-SITE.XML_ozone.scm.dead.node.interval=45s
OZONE-SITE.XML_hdds.heartbeat.interval=5s
diff --git a/hadoop-ozone/dist/src/main/compose/ozonesecure-ha/docker-config b/hadoop-ozone/dist/src/main/compose/ozonesecure-ha/docker-config
index c5beb5da91..45efd7b520 100644
--- a/hadoop-ozone/dist/src/main/compose/ozonesecure-ha/docker-config
+++ b/hadoop-ozone/dist/src/main/compose/ozonesecure-ha/docker-config
@@ -57,7 +57,6 @@ OZONE-SITE.XML_hdds.grpc.tls.enabled=true
OZONE-SITE.XML_ozone.replication=3
OZONE-SITE.XML_hdds.scmclient.max.retry.timeout=30s
OZONE-SITE.XML_hdds.container.report.interval=60s
-OZONE-SITE.XML_ozone.om.s3.grpc.server_enabled=true
OZONE-SITE.XML_dfs.container.ratis.datastream.enabled=true
OZONE-SITE.XML_ozone.recon.om.snapshot.task.interval.delay=1m
diff --git a/hadoop-ozone/dist/src/main/compose/ozonesecure/docker-config b/hadoop-ozone/dist/src/main/compose/ozonesecure/docker-config
index 471a4f144d..0b20e8bfd0 100644
--- a/hadoop-ozone/dist/src/main/compose/ozonesecure/docker-config
+++ b/hadoop-ozone/dist/src/main/compose/ozonesecure/docker-config
@@ -83,7 +83,6 @@ OZONE-SITE.XML_hdds.scm.replication.enable.legacy=false
OZONE-SITE.XML_ozone.scm.stale.node.interval=30s
OZONE-SITE.XML_ozone.scm.dead.node.interval=45s
OZONE-SITE.XML_hdds.container.report.interval=60s
-OZONE-SITE.XML_ozone.om.s3.grpc.server_enabled=true
OZONE-SITE.XML_ozone.scm.close.container.wait.duration=5s
OZONE-SITE.XML_dfs.container.ratis.datastream.enabled=true
diff --git a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java
index 8129bf0c03..5c957680de 100644
--- a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java
+++ b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java
@@ -124,7 +124,6 @@ public class TestOzoneConfigurationFields extends TestConfigurationFieldsBase {
ReconServerConfigKeys.RECON_OM_SNAPSHOT_TASK_FLUSH_PARAM,
OMConfigKeys.OZONE_OM_RATIS_SNAPSHOT_AUTO_TRIGGER_THRESHOLD_KEY,
OMConfigKeys.OZONE_OM_HA_PREFIX,
- OMConfigKeys.OZONE_OM_TRANSPORT_CLASS,
OMConfigKeys.OZONE_OM_GRPC_PORT_KEY,
// TODO HDDS-2856
OMConfigKeys.OZONE_RANGER_OM_IGNORE_SERVER_CERT,
diff --git a/hadoop-ozone/integration-test/src/test/resources/ozone-site.xml b/hadoop-ozone/integration-test/src/test/resources/ozone-site.xml
index b52aa574f9..b8139b57ce 100644
--- a/hadoop-ozone/integration-test/src/test/resources/ozone-site.xml
+++ b/hadoop-ozone/integration-test/src/test/resources/ozone-site.xml
@@ -26,6 +26,16 @@
<value>org.apache.hadoop.hdds.fs.MockSpaceUsageCheckFactory$None</value>
</property>
+ <property>
+ <name>ozone.om.transport.class</name>
+ <value>org.apache.hadoop.ozone.om.protocolPB.Hadoop3OmTransportFactory</value>
+ </property>
+
+ <property>
+ <name>ozone.om.s3.grpc.server_enabled</name>
+ <value>false</value>
+ </property>
+
<property>
<name>dfs.container.ratis.num.write.chunk.threads.per.volume</name>
<value>4</value>
diff --git a/hadoop-ozone/tools/src/main/resources/META-INF/services/org.apache.hadoop.ozone.om.protocolPB.OmTransportFactory b/hadoop-ozone/tools/src/main/resources/META-INF/services/org.apache.hadoop.ozone.om.protocolPB.OmTransportFactory
new file mode 100644
index 0000000000..21669f5982
--- /dev/null
+++ b/hadoop-ozone/tools/src/main/resources/META-INF/services/org.apache.hadoop.ozone.om.protocolPB.OmTransportFactory
@@ -0,0 +1,15 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+org.apache.hadoop.ozone.om.protocolPB.Hadoop3OmTransportFactory
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ozone.apache.org
For additional commands, e-mail: commits-help@ozone.apache.org