You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/19 14:59:07 UTC

[GitHub] [doris] morningman opened a new pull request, #16110: [fix](planner) extract common factor rule should consider not only wh…

morningman opened a new pull request, #16110:
URL: https://github.com/apache/doris/pull/16110

   …ere predicate
   
   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   This PR #14381 limit the `ExtractCommonFactorsRule` to handle only `WHERE` predicate,
   but the predicate in `ON` clause should also be considered. Such as:
   
   ```
   CREATE TABLE `nation` (
     `n_nationkey` int(11) NOT NULL,
     `n_name` varchar(25) NOT NULL,
     `n_regionkey` int(11) NOT NULL,
     `n_comment` varchar(152) NULL
   )
   DUPLICATE KEY(`n_nationkey`)
   DISTRIBUTED BY HASH(`n_nationkey`) BUCKETS 1
   PROPERTIES (
   "replication_allocation" = "tag.location.default: 1"
   );
   
   
   select * from
   nation n1 join nation n2
   on (n1.n_name = 'FRANCE' and n2.n_name = 'GERMANY')
   or (n1.n_name = 'GERMANY' and n2.n_name = 'FRANCE')
   ```
   
   There should be predicates:
   ```
   PREDICATES: `n1`.`n_name` IN ('FRANCE', 'GERMANY')
   PREDICATES: `n2`.`n_name` IN ('FRANCE', 'GERMANY')
   ```
   On each scan node.
   
   This PR fix this issue by removing the limit of `ExtractCommonFactorsRule` 
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #16110: [fix](planner) extract common factor rule should consider not only where predicate

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16110:
URL: https://github.com/apache/doris/pull/16110#issuecomment-1397863034

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #16110: [fix](planner) extract common factor rule should consider not only where predicate

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16110:
URL: https://github.com/apache/doris/pull/16110#issuecomment-1397863057

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #16110: [fix](planner) extract common factor rule should consider not only where predicate

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #16110:
URL: https://github.com/apache/doris/pull/16110#issuecomment-1397283965

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 35.11 seconds
    load time: 496 seconds
    storage size: 17119105091 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230119164336_clickbench_pr_84302.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morningman merged pull request #16110: [fix](planner) extract common factor rule should consider not only where predicate

Posted by GitBox <gi...@apache.org>.
morningman merged PR #16110:
URL: https://github.com/apache/doris/pull/16110


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] AshinGau commented on pull request #16110: [fix](planner) extract common factor rule should consider not only where predicate

Posted by GitBox <gi...@apache.org>.
AshinGau commented on PR #16110:
URL: https://github.com/apache/doris/pull/16110#issuecomment-1397861892

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org