You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/10 11:14:23 UTC
[GitHub] [shardingsphere] jacksparrow414 opened a new pull request #7734: Add test cases for HintShardingStrategy and NoneShardingStrategy
jacksparrow414 opened a new pull request #7734:
URL: https://github.com/apache/shardingsphere/pull/7734
Fixes #7707 .
Changes proposed in this pull request:
- Add test cases for HintShardingStrategy
- Add test cases for NoneShardingStrategy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #7734: Add test cases for HintShardingStrategy and NoneShardingStrategy
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7734:
URL: https://github.com/apache/shardingsphere/pull/7734#issuecomment-706535657
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=h1) Report
> Merging [#7734](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5060cd39025e8d2a4a1f68650aeffd0d451c11a9?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7734 +/- ##
============================================
- Coverage 75.20% 75.19% -0.01%
- Complexity 516 517 +1
============================================
Files 1401 1401
Lines 22426 22426
Branches 4041 4041
============================================
- Hits 16865 16864 -1
+ Misses 4474 4473 -1
- Partials 1087 1089 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/7734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
| [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/7734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `78.00% <0.00%> (-2.00%)` | `0.00% <0.00%> (ø%)` | |
| [...route/strategy/type/none/NoneShardingStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL3N0cmF0ZWd5L3R5cGUvbm9uZS9Ob25lU2hhcmRpbmdTdHJhdGVneS5qYXZh) | `100.00% <0.00%> (+25.00%)` | `1.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=footer). Last update [5060cd3...1813377](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #7734: Add test cases for HintShardingStrategy and NoneShardingStrategy
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #7734:
URL: https://github.com/apache/shardingsphere/pull/7734#issuecomment-706535657
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=h1) Report
> Merging [#7734](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5060cd39025e8d2a4a1f68650aeffd0d451c11a9?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7734 +/- ##
=========================================
Coverage 75.20% 75.20%
- Complexity 516 517 +1
=========================================
Files 1401 1401
Lines 22426 22426
Branches 4041 4041
=========================================
+ Hits 16865 16866 +1
+ Misses 4474 4473 -1
Partials 1087 1087
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...route/strategy/type/none/NoneShardingStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL3N0cmF0ZWd5L3R5cGUvbm9uZS9Ob25lU2hhcmRpbmdTdHJhdGVneS5qYXZh) | `100.00% <0.00%> (+25.00%)` | `1.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=footer). Last update [5060cd3...1813377](https://codecov.io/gh/apache/shardingsphere/pull/7734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #7734: Add test cases for HintShardingStrategy and NoneShardingStrategy
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7734:
URL: https://github.com/apache/shardingsphere/pull/7734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org